Add a flag to exclude tainted nodes #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a cluster that has many tainted nodes it's not straightforward to understand whether there is sufficient capacity to drain one: nodes with taints can make it seem like there is more capacity than there really would be. This patch solves for the simplest use case by allowing all tainted nodes to be excluded with a flag.
barrykp
force-pushed
the
barrykp/notaint
branch
from
72afb4e
to
60564c6
Compare
|
Thanks @barrykp! Sorry for the delay on getting to this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a cluster that has many tainted nodes it's not straightforward to understand whether there is sufficient capacity to drain one: nodes with taints can make it seem like there is more capacity than there really would be.
This patch solves for the simplest use case by allowing all tainted nodes to be excluded with a flag.