Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text size in uncomfortably large by-default #2

Closed
Avamander opened this issue Jan 4, 2020 · 9 comments
Closed

Text size in uncomfortably large by-default #2

Avamander opened this issue Jan 4, 2020 · 9 comments
Assignees
Labels
bug

Comments

@Avamander
Copy link

@Avamander Avamander commented Jan 4, 2020

When I visit the demo page I had to turn zoom down to 67% because the font size and column length was simply too large, both for myself and when just comparing to other sites. I'm using a 19" 5:4 1280x1024 monitor and I suspect that might be one of the causes.

This problem however does not exist with sites I've seen that use just Skeleton. Also mentioning just in case that Medium suffers from the same issue.

@robsheldon robsheldon added the bug label Jan 6, 2020
@robsheldon

This comment has been minimized.

Copy link
Owner

@robsheldon robsheldon commented Jan 10, 2020

I've been playing around with this for a few days. It's a bit puzzling. I think you're right on the money with thinking it's your display settings. I duplicated your settings on my display, and although the text is a bit large, I'm not sure I'm seeing the same thing you are. Can you post a screenshot or something?

I can't identify anything in skeleton.css that would make a big difference here. The base font size on the html element is the same and there aren't any media queries that change it. It could be that I started with a slightly larger overall font size for readability at higher dpis and it just gets too big at lower dpis.

I've been experimenting with proportional font scaling and media queries for dpi. I'm going to try to combine those to gracefully adjust font sizing for different display geometries, but a screenshot from you would help me figure out how to tweak the scaling factors.

@robsheldon robsheldon self-assigned this Jan 10, 2020
@Avamander

This comment has been minimized.

Copy link
Author

@Avamander Avamander commented Jan 10, 2020

image

image

Skeleton.css's font size is practically the last font size that is reasonable on my screen, though even reducing to 90% would be my personal preference, scaffold.css on the other hand is just a bit too large by default.

@robsheldon

This comment has been minimized.

Copy link
Owner

@robsheldon robsheldon commented Jan 10, 2020

Okay, cool. That pretty well matches what I was seeing then. I should have a fix out soon.

@robsheldon

This comment has been minimized.

Copy link
Owner

@robsheldon robsheldon commented Jan 11, 2020

Can you visit https://newventuresoftware.com/blog/pixel-density-and-resolution-tool-for-css-media-queries.html (click through the expired certificate, I guess...) and tell me what your dpi &etc. values are?

@Avamander

This comment has been minimized.

Copy link
Author

@Avamander Avamander commented Jan 11, 2020

image

@robsheldon

This comment has been minimized.

Copy link
Owner

@robsheldon robsheldon commented Jan 11, 2020

Not the numbers I was hoping for.

Okay, how does https://sscaffold-css.com/test/homepage/ look to you?

@Avamander

This comment has been minimized.

Copy link
Author

@Avamander Avamander commented Jan 11, 2020

It's much nicer, thank you.

@robsheldon

This comment has been minimized.

Copy link
Owner

@robsheldon robsheldon commented Jan 11, 2020

Okay. I'll finish testing and then commit this. Thanks for the bug report and the help in resolving it.

@robsheldon

This comment has been minimized.

Copy link
Owner

@robsheldon robsheldon commented Jan 16, 2020

Fixed for 0.1.0.

@robsheldon robsheldon closed this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.