ChronoLocalDate(Time) and ChronoZonedDateTime.isEqual

[robstoll]

Platform (jvm, js, android): jvm
Extension (none, kotlin 1.3, jdk8): jdk8

Code related feature

expect(LocalDate.now()).isEqual(JapaneseDate.now())

Following the things you need to do (same same but different for ChronoLocalDateTime<out ChronoLocalDate> and ChronoZonedDateTime<out ChronoLocalDate>

domain-lib

• add _isEqual to chronoLocalDateAssertions.kt by using ExpectImpl.builder.createDescriptive(... (see other functions)

  • add SAME_DAY("is the same day as") to DescriptionDateTimeLikeAssertion for en_GB
  • add SAME_DAY("ist derselbe Tag wie") to DescriptionDateTimeLikeAssertion for de_CH

• use the following as description for ChronoLocalDateTime and ChronoZonedDateTime

  • add IS_EQUAL_TO("is equal to") to DescriptionDateTimeLikeAssertion for en_GB
  • add IS_EQUAL_TO("ist gleichzeitig wie") to DescriptionDateTimeLikeAssertion for de_CH

domain

• add isEqual to ChronoLocalDateAssertions (see other functions as a guideline)
• modify ChronoLocalDateAssertionsBuilder, delegate to chronoLocalDateAssertions (see other functions as a guideline)
• delegate implementation to robstoll-lib in ChronoLocalDateAssertionsImpl (see other functions as a guideline)

api

• provide a fun isEqual which expects a ChronoLocalDate (see other functions as a guideline)
• add @since 0.9.0 (adopt to next release version) to KDOC of val and fun
• cover new functionality in ChronoLocalDateAssertionsSpec in specs-jvm and extend it in atrium-api-fluent-en_GB-common/src/test

Your first contribution?

• Write a comment I'll work on this if you would like to take this issue over.
  This way we get the chance to revise the description in case things have changed in the meantime,
  we might give you additional hints and we can assign the task to you, so that others do not start as well.
• See Your first code contribution for guidelines.
• Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
  (Invite yourself in case you do not have an account yet).

[robstoll]

implemented with 48c4e91