Library keep global state for WebSockets are opened in the child window #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you @Shokubeni for this and for taking the time to submit a PR along with updating the README. I'll take a closer look later this evening! |
robtaussig
approved these changes
Feb 6, 2022
Owner
|
@Shokubeni Thank you very much for this! Approved, merged, and released to react-use-websocket@3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is proposed to export function 'resetGlobalState' that allows resetting subscribers for a specific URL. There are some cases when that state can't be cleaned by the hook itself. The problem is described in the readme as an example.