icalendar >>text<< value contains escaping (\\, \;, \,, \n): #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we already unescape during parsing, but we did not escape during writing we used to fail on the second parse in "parse (to_ics (parse data))" due to bad escaping add a test from a real ics for this also, TZURL is a caladdress now (URI in RFC), instead of text use calendar_equal in test instead of polymorphic compare (which failed for the new test case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we already unescape during parsing, but we did not escape during writing
we used to fail on the second parse in "parse (to_ics (parse data))" due to
bad escaping
add a test from a real ics for this
also, TZURL is a caladdress now (URI in RFC), instead of text
use calendar_equal in test instead of polymorphic compare (which failed for
the new test case)
//cc @linse