Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icalendar >>text<< value contains escaping (\\, \;, \,, \n): #2

Merged
merged 1 commit into from Jun 30, 2019

Conversation

@hannesm
Copy link
Contributor

@hannesm hannesm commented Jun 20, 2019

we already unescape during parsing, but we did not escape during writing

we used to fail on the second parse in "parse (to_ics (parse data))" due to
bad escaping

add a test from a real ics for this

also, TZURL is a caladdress now (URI in RFC), instead of text
use calendar_equal in test instead of polymorphic compare (which failed for
the new test case)

//cc @linse

we already unescape during parsing, but we did not escape during writing

we used to fail on the second parse in "parse (to_ics (parse data))" due to
 bad escaping

add a test from a real ics for this

also, TZURL is a caladdress now (URI in RFC), instead of text
use calendar_equal in test instead of polymorphic compare (which failed for
the new test case)
@hannesm hannesm merged commit c0bffe5 into master Jun 30, 2019
2 checks passed
Loading
@hannesm hannesm deleted the fix-escape branch Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant