Fix for Chromium's new CSS column + overflow bug. #70

Merged
merged 1 commit into from Jan 7, 2017

Conversation

Projects
None yet
2 participants
Owner

robwhitaker commented Jan 6, 2017

Making the overflow container the parent of the column container instead of the same one fixed #60.

@robwhitaker robwhitaker Fix for Chromium's new CSS column + overflow bug.
Making the overflow container the parent of the column container instead of the same one fixed #60.
fd2bff9

robwhitaker requested a review from larouxn Jan 6, 2017

Owner

robwhitaker commented Jan 6, 2017

@larouxn - I think I got this fixed, but it needs more cross-browser testing. I tested in desktop Chrome, Opera, and Yandex. See if you can break it, too - it's Renderer code, so I could have intro'd unexpected errors. If everything looks okay to you, go ahead and merge this PR.

Collaborator

larouxn commented Jan 6, 2017 edited

Browsers tested:
macOS 10.12.2 - Flawless victory.

  • Chrome 55.0.2883.95 (64-bit)
  • Chrome (dev) 57.0.2973.0 (64-bit)
  • Firefox 50.1.0
  • Firefox (dev) 53.0a1 (2017-01-06) (64-bit)
  • Opera 42.0.2393.94
  • Opera (dev) 44.0.2463.0
  • Safari 10.0.2 (12602.3.12.0.1)
  • Safari (dev) 10.1 (12603.1.16) release 20
  • Yandex 16.10.0.2309 (64-bit)

Windows 10 (1607 - KB3209498) - Overall fine but Edge does crash, sometimes.

  • Chrome 55.0.2883.87 m
  • Firefox 50.1.0
  • IE11 11.576.14393.0
  • Edge 38.14393.0.0

Android 7.1.1 - Overall, not the smoothest experience but all worked.

  • Chrome 55.0.2883.91 (32-bit)
  • Chrome (dev) 57.0.2973.0
  • Firefox 50.1.0
  • Firefox (dev) 52.0a2 (2017-01-06)

iOS - Reader works perfectly. Footer still doesn't wrap on iPhone.

  • Mobile Safari (iPhone)
  • Mobile Safari (iPad)
@larouxn

larouxn approved these changes Jan 7, 2017

Tested in an absolute plethora of browsers. LGTM, nice work! 👍

@robwhitaker robwhitaker merged commit 82937f8 into staging Jan 7, 2017

larouxn deleted the ChromiumFix branch Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment