Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the library #10

Merged
merged 4 commits into from Oct 2, 2021
Merged

Update the library #10

merged 4 commits into from Oct 2, 2021

Conversation

thomasbnt
Copy link
Contributor

  • Added resize: none to the .tweet div to not be able to change the size of the input on the smartphone.
  • Async JS code
  • Autofocus to the Generate button
  • Changed textContent to 274 because Twitter add a final space at the end of the tweet

Preview Twitter

I can add some text to resolve the #9 issue like "What is The Library of Babel?" and link to this GitHub repo.

@thomasbnt
Copy link
Contributor Author

thomasbnt commented Oct 1, 2021

Why WIP?

If you want, I can change more informations on the page. 💪🏼☕

@rocambille rocambille merged commit 5c59ce1 into rocambille:main Oct 2, 2021
@rocambille
Copy link
Owner

that's great, thx a lot 😃

if you want to work on #9, yes go ahead 👍

@thomasbnt thomasbnt deleted the update-the-library-thomasbnt branch October 2, 2021 12:34
@thomasbnt
Copy link
Contributor Author

@rocambille I see your repository on DEV for the Hacktoberfest event ☕👏🏼

I didn't know the Library of Babel 👀

@rocambille
Copy link
Owner

@thomasbnt worth the read, but you can first check the hints I just added in the issue 😉

@thomasbnt thomasbnt changed the title WIP? — Update the library Update the library Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants