Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upC extension with SWIG (counting bytes, not characters) #7
Conversation
This comment has been minimized.
This comment has been minimized.
rochacbruno
commented on f8e36ab
Nov 17, 2017
|
Hey! nice! can you send a Pull Request @martinxyz I would like to add your C implementation to the repo and article |
This comment has been minimized.
This comment has been minimized.
rochacbruno
replied
Nov 17, 2017
|
Hi, I opened the PR myself, and will adjust and add to the repo, thanks |
This comment has been minimized.
This comment has been minimized.
|
Ah I didn't expect you'd want to integrate it. Looks all done now, so thanks :-) |
This comment has been minimized.
This comment has been minimized.
|
To do
|
This comment has been minimized.
This comment has been minimized.
|
Thanks @martinxyz and @cuviper I am going to commit the new implementations and see the results |
rochacbruno
merged commit f8e36ab
into
rochacbruno:master
Nov 17, 2017
This comment has been minimized.
This comment has been minimized.
|
Nice update! By the way, I did not implement bytes because it was faster, but because I had no clue at all how to do this correctly in C. (And I'm not going to try if I can use Rust instead.) |

rochacbruno commentedNov 17, 2017
•
edited
by @martinxyz
Note: the comparision is not really fair because the C extension is comparing
bytes, while python and rust are comparing utf8 characters.