diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3a55eab..473dd6f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,4 +2,4 @@ What is the pull request about? What changes were made? ## Linked Issue -Closes issue #_ +Closes #_ diff --git a/util/hook.go b/util/hook.go index 8c3e0ce..9e4a914 100644 --- a/util/hook.go +++ b/util/hook.go @@ -51,7 +51,10 @@ func DeleteHook(path, _ string) error { } func writeContent(writer io.Writer, exePath string) { - _, err := fmt.Fprintf(writer, `#!/bin/sh\n\n"%s/commit-message-check" validate $1\n`, exePath) + _, err := fmt.Fprint(writer, "#!/bin/sh\n\n") + _, err = fmt.Fprintf(writer, `"%s/commit-message-check" validate $1`, exePath) + _, err = fmt.Fprint(writer, "\n") + if err != nil { log.Printf("[ERROR]\t Could not write commit-msg script: %s", err) } diff --git a/util/hook_test.go b/util/hook_test.go index 2767c48..fda7c7a 100644 --- a/util/hook_test.go +++ b/util/hook_test.go @@ -134,7 +134,7 @@ func TestWriteContent(t *testing.T) { writeContent(buffer, "usr/tmp") - assert.Contains(t, buffer.String(), `#!/bin/sh\n\n`) + assert.Contains(t, buffer.String(), "#!/bin/sh\n\n") }) t.Run("executes commit-message-check with root path and quotes path to handle spaces", func(t *testing.T) { @@ -142,7 +142,15 @@ func TestWriteContent(t *testing.T) { writeContent(buffer, "usr/tmp") - assert.Contains(t, buffer.String(), `"usr/tmp/commit-message-check" validate $1\n`) + assert.Contains(t, buffer.String(), `"usr/tmp/commit-message-check" validate $1`) + }) + + t.Run("inserts a blank line at the end of file", func(t *testing.T) { + buffer.Reset() + + writeContent(buffer, "usr/tmp") + + assert.Contains(t, buffer.String(), "$1\n") }) t.Run("logs any error", func(t *testing.T) {