Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera Property Overhaul and Expansion #2

Merged
merged 33 commits into from Jun 7, 2015

Conversation

Projects
None yet
2 participants
@FluxIX
Copy link
Contributor

commented Jun 6, 2015

I've implemented a different interface to the camera properties. I've also integrated the camera property control into the WinForm Demo.

I think there are some other bug fixes as well.

FluxIX added some commits May 2, 2015

Added functionality to set the camera control properties as well as r…
…etrieve the list of supported capture sizes.
Changed the target framework profile to target the client framework. …
…Turned on code analysis. Removed the reference the WebCam.dll build artifact and added a reference to the WebCam project.
Added the code to interface with the enhanced WebCam code (the camera…
… control properties, capture sizes, capture color depth). Also added thread-locking to the _cameraMethods accesses.
Made the StartCamera function boolean returning (indicating success).…
… Also corrected a Listener unregistration in CameraFrameSource.cs.
Add a set of get and set property functions which take in a boolean p…
…arameter describing if the value is a value or a percentage.
Made the CameraPropertyValue a writable object. Also made the CameraP…
…ropertyValue and CameraPropertyRange classes implement IComparable<T> and IEquatable<T>.
Added checks in the comparison functions which preemptively check if …
…the two objects being compared have the same address.
Corrected a CameraProperty enumeration declaration error. Made the Ge…
…tPropertyCapability function only try to get the set capabilities is the get is supported.

rockstardev pushed a commit that referenced this pull request Jun 7, 2015

lepipele
Merge pull request #2 from FluxIX/master
Camera Property Overhaul and Expansion

@rockstardev rockstardev merged commit 02aba90 into rockstardev:master Jun 7, 2015

@rockstardev

This comment has been minimized.

Copy link
Owner

commented Jun 7, 2015

@FluxIX thanks for the pull request - I have few questions on some stuff, but let me first merge and ask questions later when I fully review code.

I'll also update the article with thank you notice.

@FluxIX

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2015

I haven't any questions come back. Are you still reviewing or are there no questions?

@rockstardev

This comment has been minimized.

Copy link
Owner

commented Jun 9, 2015

Still reviewing; I was looking if I can somehow simplify that Camera Property Controls region.

Also, can you verify that resolution setting is now properly working in C++? I talk about that here:
http://www.codeproject.com/Articles/125478/Versatile-WebCam-C-library#Problem

Previously _cameraMethods.StartCamera() was using width & height at all... but this was supposedly fixed by btnr. On my machine it looks fine, but I was wondering if you took a look at this at all / did anything with it?

Code I am talking about is in Camera.cs@1014 - you'll see comments explaining the code

@FluxIX

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2015

I verified the resolution in the C++ code (I have three machines at work currently which this code runs on, and I needed it to run in 640x480 instead of 320x240 for the application I was writing). I needed to fix the resolution to get it to work (I actually also know the color depth selection works as that was a problem I ran into on one of the test machines).

I did not touch the referenced Camera.cs code, but I think it will need to be updated to take into account the color depth (otherwise you get an undebuggable exception indicating you're access memory you shouldn't). It shouldn't be difficult to update though.

@FluxIX

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2015

Were there any other questions regarding the contents of the pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.