Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Duplicati to the image by linuxserver.json #207

Merged
merged 2 commits into from Dec 2, 2019

Conversation

FroggyFlox
Copy link
Member

@FroggyFlox FroggyFlox commented Dec 1, 2019

Fixes #206.
`

General information on project

This pull request proposes to add a new rock-on for the following project:

  • name: Duplicati
  • website: https://duplicati.com
  • description: Free backup solution compatible with a wide-range of services.

Information on docker image

Checklist

  • Passes JSONlint validation
  • Entry added to root.json in alphabetical order (for new rock-on only)
  • "description" object lists and links to the docker image used
  • "description" object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)
  • "website" object links to project's main website

Copy link
Member

@phillxnet phillxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FroggyFlox Nice pr as usual and thanks for stepping up to this so quickly.

Could you review my suggested change and once sorted I can merge, test as a whole and publish if all is well.

root.json Outdated Show resolved Hide resolved
Co-Authored-By: Philip Guyton <phillxnet@users.noreply.github.com>
@FroggyFlox
Copy link
Member Author

Thanks for catching that, @phillxnet. It was my intent to remove it but I somehow forgot it... my apologies. I committed your suggestion so it should be fine now.

@phillxnet
Copy link
Member

phillxnet commented Dec 1, 2019

@FroggyFlox Thanks for that.

I should be able to get this published shortly; just got to get done with my current task and I'll give it a final test and publish there after.

Thanks again for sorting this out. Nice to have yet another linuxserver.io offering. I'll comment here once it's published.

@phillxnet
Copy link
Member

@FroggyFlox Just done final pre-merge test and all looks to be good.

Apologies for the delay here. Just about to merge and should be publishing shortly their after.

@phillxnet phillxnet merged commit de26799 into rockstor:master Dec 2, 2019
@phillxnet
Copy link
Member

@FroggyFlox OK, now published. Miles better than our last offering. Well done.

I particularly like the info section. I did manages to break my test instance but given it's in beta that may not be surprising. We can keep an eye on this and once available move this to a stable variant.

Even after wiping all config I ended up, after some abuse re turning off mid config mind, with no Web-UI for this Rock-on. Uninstall and re-install still no joy and had to in the end do a:

/opt/rockstor/bin/delete-rockon linuxserver/duplicati

Then re-install. So don't know what happened their. Do have some logs but let see how regular use pans out as I'm not a current user of Duplicati so my partial config ON/OFF with additional shares added may just have pushed the beta status over the edge.

All the same it's great to have this updated. Thanks for this and to @HBDK in the linked issue for their input on and raising the indicated issue.

@FroggyFlox
Copy link
Member Author

Thanks a lot, @phillxnet!

Even after wiping all config I ended up, after some abuse re turning off mid config mind, with no Web-UI for this Rock-on. Uninstall and re-install still no joy and had to in the end do a:

/opt/rockstor/bin/delete-rockon linuxserver/duplicati

Then re-install.

That is curious indeed... That sounds like some config remained even though you wiped all volumes... another incentive for me to tackle a user-friendly way to do this kind of "maintenance" from Rockstor's webUI once the other, more pressing, issues are behind us.

@FroggyFlox FroggyFlox deleted the Issue206_Update_Duplicati branch February 3, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmaintained and outdated duplicati?
2 participants