Rename bitwarden rs to vaultwarden

[RlndVt]

Fixes #296.

E:
Expanded to also fix #298 .

[phillxnet]

@RlndVt & @Hooverdan96 Well done on resolving the related arm issue re #298.

Are we now just awaiting @Hooverdan96 's suggestions in that issue re:

#298 (comment)

So, I think, once the description in #297 is updated to include the available architecture language, then this could likely be closed.

The only architectures we are interested in are x86_64 & ARM64 really. The v7 arms are way under-powered for Rockstor and btrfs.

@RlndVt do you mind updating this pr's original text to list it's (welcome in this case) scope creep? I.e. it looks like it also fixes the arm compatibility/description (with edits) issue so another "Fixes" line could be added for example. All helps with assessing the state as this one is getting a little confusing with it's 3 associated issues :). All good.

Cheers. Almost there on this one by the looks of it. And thanks again for all you efforts. It will be good to get this one done and dusted.

[RlndVt]

Squashed the root.json commits as they shouldn´t be considered separate from the rest.

[FroggyFlox]

Hi @RlndVt ,

First, please accept my apologies for taking so long to have a proper look at this. I've tested it on amd64 and it works as intended. I'll try to test it on an arm64 machine later today to make sure that works as well but in the meantime I thought I would make a suggestion to add this multi-architecture compatibility. Feel free to commit that suggestion when you get a chance.

Thanks again for submitting this PR and keeping this Rock-on up-to-date!

[FroggyFlox]

@RlndVt ,

I just tested on both amd64 and arm64 architectures and it works like a charm. I created a self-signed certificate in the share to be used as "vaultwarden certificates":

openssl req -newkey rsa:2048 -nodes -keyout key.pem -x509 -days 365 -out certs.pem

... then installed the Rock-on and it all works as intended:

• installs without error
• webUI is accessible
• restarts normally
• restarts automatically and without error after a reboot
• can be uninstalled and re-installed without a problem

I think we are ready to merge this in as soon as we have the little edits related to the explicit mention of the multi-arch compatibility in the Rock-on "description" field.

Thanks a lot!

[FroggyFlox]

Thanks for the additional edits, @RlndVt !

I'll merge this now.

[FroggyFlox]

This has now been published. Thanks again @RlndVt !