New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitch in SMART error log UI #1001

Closed
haoto opened this Issue Nov 5, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@haoto

haoto commented Nov 5, 2015

Another small glitch in the Web UI. The SMART error log is not sorted correctly. I have a failing disk whose error log shows:

Error # Lifetime hours State Type Details
99 3652 active or idle. UNCorrectable Error in Data at LBA = 0x0e606b00 = 241199872
103 3652 active or idle. UNCorrectable Error in Data at LBA = 0x0e606b00 = 241199872
102 3652 active or idle. UNCorrectable Error in Data at LBA = 0x0e606b00 = 241199872
101 3652 active or idle. UNCorrectable Error in Data at LBA = 0x0e606b00 = 241199872
100 3652 active or idle. UNCorrectable Error in Data at LBA = 0x0e606bb8 = 241200056

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Jan 17, 2016

Member

@haoto I had a quick look at this but I'm afraid I would need an exact sample of the output you have given in order to test a fix.
Could you execute the following command on a Rockstor console and email the output file to support@rockstor.com.
N.B. the "sda" part must match the current device name for the error log order problem drive.

/usr/sbin/smartctl -l error /dev/sda > smart-l-error-order-problem.out

so what we need is the "smart-l-error-order-problem.out" file that results. This way any patch to address this ordering can be tested on your rather poorly drives output.

Please also include a link to this issue in your email.

Thanks.

Member

phillxnet commented Jan 17, 2016

@haoto I had a quick look at this but I'm afraid I would need an exact sample of the output you have given in order to test a fix.
Could you execute the following command on a Rockstor console and email the output file to support@rockstor.com.
N.B. the "sda" part must match the current device name for the error log order problem drive.

/usr/sbin/smartctl -l error /dev/sda > smart-l-error-order-problem.out

so what we need is the "smart-l-error-order-problem.out" file that results. This way any patch to address this ordering can be tested on your rather poorly drives output.

Please also include a link to this issue in your email.

Thanks.

@schakrava schakrava modified the milestones: Looney Bean, Kilauea Iki Feb 28, 2016

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Nov 4, 2016

Member

Having a quick look at this issue by first generating some test data via the script just developed in #1507 as the requested command output from the original reporter was not submitted.

Planning to modify an existing faulty drive's error report to reproduce the observed sorting anomaly locally via the test-mode of src/rockstor/system/smart.py.

Member

phillxnet commented Nov 4, 2016

Having a quick look at this issue by first generating some test data via the script just developed in #1507 as the requested command output from the original reporter was not submitted.

Planning to modify an existing faulty drive's error report to reproduce the observed sorting anomaly locally via the test-mode of src/rockstor/system/smart.py.

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Nov 4, 2016

Member

Addressing as part of Looney Bean Milestone.

Member

phillxnet commented Nov 4, 2016

Addressing as part of Looney Bean Milestone.

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Nov 5, 2016

Member

OK, I have recreated this issue using a fabricated smartctl -l error output based on a real drive that had over 100 errors logged, the numbers of these errors were then edited to duplicate those of the original posters example, ie 99-103:

Error # Lifetime hours  State   Type    Details
99  1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
103 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
102 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
101 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
100 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
Member

phillxnet commented Nov 5, 2016

OK, I have recreated this issue using a fabricated smartctl -l error output based on a real drive that had over 100 errors logged, the numbers of these errors were then edited to duplicate those of the original posters example, ie 99-103:

Error # Lifetime hours  State   Type    Details
99  1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
103 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
102 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
101 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
100 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Nov 5, 2016

change SMART error log summary sort from lexical to int #1001
By changing to int ordering from lexicographical we ensure
numeric ordering of the errors in the error log summary display.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Nov 5, 2016

sort SMART attributes alphabetically #1001
Previously the display order of attributes was arbitrary.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Nov 5, 2016

sort SMART capabilities alphabetically #1001
Previously the display order of capabilities was arbitrary.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Nov 5, 2016

remove id table column in SMART capabilities view #1001
The id column was arbitrary and not present in the:
smartctl -c output.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Nov 5, 2016

lead SMART attributes table with Name column #1001
Moved the Attributes Id column from the beginning to
the end of the table. As this is a human view it makes
sense to lead with the now alphabetically sorted name
column rather than the id column, however reference
via the id column is still afforded by the edge table position.
@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Nov 5, 2016

Member

By switching from lexical to integer sort we have the following ordering for the same test error log data:

Error # Lifetime hours  State   Type    Details
103 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
102 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
101 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
100 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
99  1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
Member

phillxnet commented Nov 5, 2016

By switching from lexical to integer sort we have the following ordering for the same test error log data:

Error # Lifetime hours  State   Type    Details
103 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
102 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
101 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
100 1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091
99  1953    active or idle. UNCorrectable Error in Data 5 sectors at LBA = 0x0078744b = 7894091

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Nov 5, 2016

consistently bold SMART name columns in table views #1001
As the Attribute name column entries in the Identity table
are bolded it makes for a more consistent and readable
presentation if we also bold the now leading name columns
in the Attributes and Capabilities tables.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Nov 5, 2016

bold SMART 'Raw Value' Attributes table column entries #1001
Although the Normalized value is sometimes more relevant, the
common values referenced are often in the raw values column,
and the bolding of the leading name column and this mid
position column 'bracket' the other contextually relevant
columns of normalized, worst, and Threshold values.

@schakrava schakrava closed this in #1508 Nov 13, 2016

schakrava added a commit that referenced this issue Nov 13, 2016

Merge pull request #1508 from phillxnet/1001_Glitch_in_SMART_error_lo…
…g_UI

glitch in smart error log ui, plus cosmetic table changes Fixes #1001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment