Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Access control issue found on latest unstable/test updates #1100

Closed
parker1c opened this issue Jan 14, 2016 · 5 comments
Closed

Share Access control issue found on latest unstable/test updates #1100

parker1c opened this issue Jan 14, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@parker1c
Copy link

I believe I found some bug with "Access control" in a share a user makes and then edits. I can repeat the issue as I wasn't sure what broke until after some testing.

Symptoms: When editing a created share's permissions,(in the webgui) for example: enabling read/write/execute for all 3, owner/group/other (for example 777). Upon saving, it then goes to read only for owner/group/other (444), despite selecting other options.

Default install of 3.8-10(Linux: 4.2.5-1.el7.elrepo.x86_64) ISO does not exhibit this behaviour. Upon activating Testing updates, and installing/rebooting (Rockstor 3.8-10.17) (Linux: 4.3.3-1.el7.elrepo.x86_64), the above symptoms now arrive.

Installing updates after clean install are only things done. New or old shares created and then edited now present the "read only" option despite selecting other options for access control.

@phillxnet
Copy link
Member

@parker1c Thanks for reporting this and your diligence in the details. I haven't had a chance to look into this myself just yet but hopefully I or someone can sort this pretty soon.

Any progress on this issue will be logged here.
Cheers.

@schakrava schakrava added the bug label Jan 16, 2016
@schakrava schakrava added this to the Kilauea Iki milestone Jan 16, 2016
@schakrava schakrava self-assigned this Jan 16, 2016
@phillxnet
Copy link
Member

@schakrava I am having a quick look at this currently. Do let me know if this is inappropriate. I'm hoping its another simple fix akin to my recent run. I will report here how it goes. I have confirmed @parker1c findings in a simple share creation.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 16, 2016
Also correct value entries for edit_write_permissions and
edit_execute_permissions.
@phillxnet
Copy link
Member

@parker1c Thanks again for bringing attention to this issue. A patch has now been submitted, referenced in this issue thread, and if it passes review then it should be available soon via an update.

Cheers for contributing your time and testing talent.

@Mazo
Copy link
Contributor

Mazo commented Jan 16, 2016

After updating to the latest version of Rockstor (testing branch) it appears to have reset all my shares to the default permissions (oddly). Once the patch is merged and released I'll try reassigning permissions and see if it's working.

schakrava added a commit that referenced this issue Jan 17, 2016
mend share permissions edit in testing channel. Fixes #1100
@phillxnet
Copy link
Member

@parker1c As of the just released 3.8-10.18 (testing channel) the referenced patch for this issue should now be included, and it appears from the dev log that the next stable channel update is just around the corner.
http://forum.rockstor.com/t/dev-log-for-upcoming-3-8-11-latest-3-8-10-18/792/33

Thanks for you help with this matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants