New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockstor version not always visible #1119

Closed
phillxnet opened this Issue Jan 24, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@phillxnet
Member

phillxnet commented Jan 24, 2016

Thanks to @grizzly on the forum for highlighting. It is often the case that the Rockstor version is not displayed in the top right of the WebUI as intended. It would be good to make this more reliable. Workaround is to visit the System - Software Update page and if there is a pending update it sometimes provokes the WebUI into displaying the current Rockstor version.

Please update the following forum thread with development on this issue.
http://forum.rockstor.com/t/how-to-tell-current-version/963

@schakrava schakrava added the bug label Jan 24, 2016

@schakrava schakrava added this to the Kilauea Iki milestone Jan 24, 2016

@Mazo

This comment has been minimized.

Contributor

Mazo commented Jan 27, 2016

Believe this is likely down to line 310 in /smart_manager/data_collector.py

If the refresh timer hasn't expired update_check() never runs, which means displayUpdate() never gets called by the socket listener on line 974 in /storageadmin/static/storageadmin/js/router.js

@schakrava

This comment has been minimized.

Member

schakrava commented Jan 27, 2016

Thanks for the tip @Mazo. We'll get to it soon, but feel free to open a pull request if you like. greatly appreciate it!

@phillxnet

This comment has been minimized.

Member

phillxnet commented Jan 29, 2016

This is now much improved for me as from 3.8-11.02; if the view is wide enought to display the individual menus then within a minute or so of a broswer refresh I get the version displayed.

@schakrava Is this now fixed by #1133 then?

@schakrava schakrava closed this in c14236f Feb 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment