Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GID is ignored when creating group #1161

Closed
TheFluffyOne opened this Issue Feb 10, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@TheFluffyOne
Copy link

TheFluffyOne commented Feb 10, 2016

When creating a group via the web UI, if I enter a specific GID it is ignored. For example, I create a group called "accesstest", putting 10099 into the GID field and submit. The group is created with the next sequentially-available GID, for example "10016" in the case of a test I just ran.

It appears that the GID field is being ignored. Doesn't seem to make a difference whether I choose to put the group under "Rockstor management" or not.

@TheFluffyOne

This comment has been minimized.

Copy link
Author

TheFluffyOne commented Feb 10, 2016

Tested on Rockstor version 3.8-11.09.

@TheFluffyOne

This comment has been minimized.

Copy link
Author

TheFluffyOne commented Feb 10, 2016

Just had a quick poke around (pretty crudely, I'm afraid, as I'm not familiar with your codebase or NGINX). The issue appears to be that the GID is not being included in the POST. Added the request body to the NGINX logging config, and the POST request for a new group was like this:

192.168.137.1 - - [10/Feb/2016:17:41:05 +0000] "POST /api/groups HTTP/1.1" 200 311 "https://192.168.137.185/?domain=&server=" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.103 Safari/537.36" "-""{\x22groupname\x22:\x22aatest5\x22}"

If I get some more time later I'll see if I can figure out the UI templates to see what's wrong...

@schakrava schakrava closed this in e54226f Feb 18, 2016

schakrava added a commit that referenced this issue Feb 18, 2016

Merge pull request #1169 from schakrava/1161_gid
pass gid as part of payload. Fixes #1161
@schakrava

This comment has been minimized.

Copy link
Member

schakrava commented Feb 18, 2016

Thanks for reporting this issue @TheFluffyOne! It's fixed now and released in 3.8-11.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.