Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
improve root not in partition behaviour #1164
With an mdraid install (system disk) where root (btrfs) is on for example md126, ie not in a partition, the Disks page fails to display the system disk and the rockstor_rockstor pool is also not found.
Next step is to use the new info re mdraid member disks returned from the patched scan_disks() in _update_disk_state() which I have to modify for this purpose, along with a Disks model extension so that we can have disks.js know from the expanded Disks model that our mdraid host drives are not to be wiped but identified for what they are.
I hope to continue with this tomorrow. The expanded Disks model should also be useful for identifying / tagging drives in the db for special purposes, ie outside of the current btrfs data drives or system drive / drives.
@schakrava Looks like this is now working as intended and I don't see any regressions.
The following shows the above removed drive after it is re-attached:-
And finally a pure software mdraid, ie btrfs directly on md125 which is made from a partition on each of sda and sdb as is swap and boot, vda in this case has a partition and non btrfs on to indicate the cog flagging and the removed drive is to test that flag:-
Normal non mdraid system disk install ie sda3 has also been manually tested as working as expected.
On the above basis I will prepare a pr ready for review.