Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
smart commands act on root partition not root device #1206
When gathering smart info the partition device name for root is used rather than the base device name.
and we have a return code of 4 (via $?)
Where as if we use the base device name of sdc:
we have a generic return code of 1 (via $?) and in the second instance we have helpful info on what is wrong and a suggestion on what to try which would be nice not to loose.
These examples were as a result of an install to a SanDisk Extreme USB 3.0 which as the second example suggests, requires custom smartctl options (-d sat as it goes); but with the current call to partition this is not surfaced. Hence the suggestion we move to calling only on base devices.
I am currently looking into this issue and hope to make some more progress tomorrow (UK).
I am considering this issue as a precursor to #1079 as if sorted then the suggestion that additional custom smart options may be required will be surfaced.
A parsing issue I'm sorting while here is that of inadvertent smart value trimming when values contain a ": " in the Identity tab (from smartctrl -H --info devname):
when they should read: