New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue on web ui - "Total capacity, allocation and usage" widget not resizing #1225

Closed
MFlyer opened this Issue Mar 22, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@MFlyer
Member

MFlyer commented Mar 22, 2016

As for my title, here are 2 screenshots:

Widget enlarged don't fit container size
widget enlarged

Dashboard reloaded widget ok on large format
Widget reduced overfit div
over

All others seem ok
This is a really really minor issue, i know it

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Mar 22, 2016

Member

@MFlyer Thanks for reporting, minor or not. Nice find.
Just reproduced here on Chrome Version 49.0.2623.87 and Firefox 45.0 in Fedora 23.

Total Capacity widget in top left, expand (widget contents doesn't rescale), refresh browser and widget contents refreshes to large then reduce widget again and as you found widget contents are not rescaling to the new smaller widget size either.

So looks like this particular widget's contents are not auto resizing like the others do.
Good to know.

Member

phillxnet commented Mar 22, 2016

@MFlyer Thanks for reporting, minor or not. Nice find.
Just reproduced here on Chrome Version 49.0.2623.87 and Firefox 45.0 in Fedora 23.

Total Capacity widget in top left, expand (widget contents doesn't rescale), refresh browser and widget contents refreshes to large then reduce widget again and as you found widget contents are not rescaling to the new smaller widget size either.

So looks like this particular widget's contents are not auto resizing like the others do.
Good to know.

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Apr 9, 2016

Member

More info about this bug, found where it fails:

Uncaught TypeError: this.setGraphDimensions is not a function

Same time on Dashboard we get errors on element too - @schakrava @priyaganti

Member

MFlyer commented Apr 9, 2016

More info about this bug, found where it fails:

Uncaught TypeError: this.setGraphDimensions is not a function

Same time on Dashboard we get errors on element too - @schakrava @priyaganti

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Apr 26, 2016

#1225 actually resize func fires setGraphDimensions - non existing fu…
…nction on storage_metrics. Workaround: call setDimensions(), setupSvg() and renderMetrics() like on first render and resize works

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Apr 30, 2016

#1225 actually resize func fires setGraphDimensions - non existing fu…
…nction on storage_metrics. Workaround: call setDimensions(), setupSvg() and renderMetrics() like on first render and resize works

schakrava added a commit to schakrava/rockstor-core that referenced this issue May 10, 2016

@schakrava schakrava added the bug label May 11, 2016

@schakrava schakrava added this to the Looney Bean milestone May 11, 2016

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava May 11, 2016

Member

Fixed by #1293

Member

schakrava commented May 11, 2016

Fixed by #1293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment