New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Alerts Setting Missing Username #1228

Closed
wingrunr21 opened this Issue Mar 23, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@wingrunr21

wingrunr21 commented Mar 23, 2016

Hi,

It would be great if there was an option to specify a specific username in Email Alerts vs assuming it is the same as the "From" address. My specific case is that I use SparkPost for transactional emails and they require a username of 'SMTP_Injection' for SMTP connections (this is the same for all SparkPost accounts).

Thanks!

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Apr 12, 2016

Member

Hi @wingrunr21, working on it 😉

Member

MFlyer commented Apr 12, 2016

Hi @wingrunr21, working on it 😉

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Apr 12, 2016

@wingrunr21

This comment has been minimized.

Show comment
Hide comment
@wingrunr21

wingrunr21 commented Apr 12, 2016

Great!

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Apr 12, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Apr 12, 2016

#1228 email.js modified to handle new username field - rules to requi…
…red depending on checkbox selection plus some animation with toggle
@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Apr 12, 2016

Member

Hi again @wingrunr21, here is a little preview on frontend side - working and testing on backend, hope to pull request tomorrow
https://youtu.be/zLgH3D6lNm4

Member

MFlyer commented Apr 12, 2016

Hi again @wingrunr21, here is a little preview on frontend side - working and testing on backend, hope to pull request tomorrow
https://youtu.be/zLgH3D6lNm4

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Apr 13, 2016

#1228 email.py model - added field username although not really requi…
…red to be stored in db for email system to work

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Apr 13, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Apr 13, 2016

schakrava added a commit that referenced this issue Apr 15, 2016

Merge pull request #1262 from MFlyer/issue#1228_add_username_to_mail_…
…alerts_settings

Issue #1228 add username to mail alerts settings
@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava Apr 15, 2016

Member

Fixed by #1262

Member

schakrava commented Apr 15, 2016

Fixed by #1262

@schakrava schakrava closed this Apr 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment