New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve umount_root behavior #1242

Closed
schakrava opened this Issue Apr 3, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@schakrava
Member

schakrava commented Apr 3, 2016

The current pattern is to check if a mount exists and if not, then umount it. In rare occasions, it results in mount disappearing right after the check and before umount causing umount_root to fail. Better to just umount and interpret the error. Error code(32) is useless because it's the same for other errors like invalid mount point etc.. So rely on the substring in the error message "not mounted"

@schakrava schakrava self-assigned this Apr 3, 2016

@schakrava schakrava added the bug label Apr 3, 2016

@schakrava schakrava added this to the Looney Bean milestone Apr 3, 2016

schakrava added a commit to schakrava/rockstor-core that referenced this issue Apr 11, 2016

@schakrava schakrava closed this in 248ca19 Apr 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment