New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows previous version tab: Time offset #1252

Closed
fkurth opened this Issue Apr 9, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@fkurth

fkurth commented Apr 9, 2016

You decided to save the automatic share snapshots in a format like

.share_201604091525

The timestamp format is local time, as configured during the installation.
By default, samba is set to expect UTC here, as described in the doc here:

https://www.samba.org/samba/docs/man/manpages/vfs_shadow_copy2.8.html

This leads to an time offset in the windows prevous version tab by the differnce of the user local time including DST.

Adding
shadow:localtime = yes
to each share entry in smb.conf fixes this. Please add this entry.

Anyway i would recommend to use the default naming "@GMT-%Y.%m.%d-%H.%M.%S"
for the snapshots and do the formatting in the GUI, with timestamp timezone translation.
Having timestamps in local time will lead to further problems if the user changes the machine timezone and so on. Thats probably the reason for v_shadow_copy's default settings.

@fkurth

This comment has been minimized.

Show comment
Hide comment
@fkurth

fkurth Apr 10, 2016

Using the default format @GMT- would also eliminate the need for the error-prone "snapshot-prefix"

fkurth commented Apr 10, 2016

Using the default format @GMT- would also eliminate the need for the error-prone "snapshot-prefix"

@schakrava schakrava added this to the Pinnacles milestone Jun 13, 2016

@schakrava schakrava self-assigned this Jun 13, 2016

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava Jun 13, 2016

Member

Thanks for filing this issue and nicely articulating the details.

Member

schakrava commented Jun 13, 2016

Thanks for filing this issue and nicely articulating the details.

@schakrava schakrava closed this in 1b54c05 Aug 30, 2016

schakrava added a commit that referenced this issue Aug 30, 2016

Merge pull request #1417 from MFlyer/issue#1252_Previous_version_tab_…
…windows

Fixes #1252 adding samba shadow localtime param

@schakrava schakrava assigned MFlyer and unassigned schakrava Nov 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment