New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make services configure forms as modals #1278

Closed
priyaganti opened this Issue Apr 20, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@priyaganti
Contributor

priyaganti commented Apr 20, 2016

  1. When clicked on the wrench icon (configure option) on some services in the services view, configure form open up in another page. Instead make it open a modal and ask the user to submit form inside the modal.
@ScarabMonkey

This comment has been minimized.

Show comment
Hide comment
@ScarabMonkey

ScarabMonkey Apr 28, 2016

Contributor

It's worth noting that some service pages currently enable the service once it is configured, whereas others don't.
With a switch to modal configuration dialogues, I would propose that all services require explicit enabling after configuration.

Contributor

ScarabMonkey commented Apr 28, 2016

It's worth noting that some service pages currently enable the service once it is configured, whereas others don't.
With a switch to modal configuration dialogues, I would propose that all services require explicit enabling after configuration.

@schakrava schakrava added this to the Looney Bean milestone Jun 13, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016

#1278 - Changed configure_services view - On submit successful or for…
…m cancel we go back to services hiding modal window

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016

Fixes #1278 - Modified configuration templates for all services havin…
…g one, now better fit on modal - ready to merge/review

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016

#1278 - Changed configure_services view - On submit successful or for…
…m cancel we go back to services hiding modal window

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016

Fixes #1278 - Modified configuration templates for all services havin…
…g one, now better fit on modal - ready to merge/review

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 15, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 15, 2016

#1278 - Changed configure_services view - On submit successful or for…
…m cancel we go back to services hiding modal window

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 15, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 15, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 15, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 16, 2016

#1278 #1529 Firefox no element found related to bad dataType on ajax …
…request, DRF returns html not json

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 16, 2016

#1278 #1529 Move modal div to an higher level outside of maincontent,…
… getting cleaned and refilled on every new socket data received

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 16, 2016

#1278 #1529 Cleaned services.js view, function handling modal hiding …
…moved to upper level

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 16, 2016

Ref to #1278 and Fixes #1529 too
configureService func now doesn't cleanup (we're not moving to a new page anymore)
Check detailed explanation over router.js
Binding modal getting hidden moved here from services.js view (all up from view to upper level)

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

@schakrava schakrava closed this in 2a1cbfb Nov 17, 2016

@schakrava schakrava assigned MFlyer and unassigned priyaganti Nov 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment