Make services configure forms as modals #1278

Closed
priyaganti opened this Issue Apr 20, 2016 · 1 comment

Projects

None yet

4 participants

@priyaganti
Contributor
  1. When clicked on the wrench icon (configure option) on some services in the services view, configure form open up in another page. Instead make it open a modal and ask the user to submit form inside the modal.
@ScarabMonkey
Contributor

It's worth noting that some service pages currently enable the service once it is configured, whereas others don't.
With a switch to modal configuration dialogues, I would propose that all services require explicit enabling after configuration.

@schakrava schakrava added this to the Looney Bean milestone Jun 13, 2016
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016
@MFlyer MFlyer #1278 - Init commit over modal config - Grant on modal get hidden app…
…router goes back to services
e953dcb
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016
@MFlyer MFlyer #1278 - Changed configure_services view - On submit successful or for…
…m cancel we go back to services hiding modal window
e4d9c8c
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016
@MFlyer MFlyer #1278 - Changed configure_services view - Indentation 0f0d3f8
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016
@MFlyer MFlyer #1278 - Updated router.js to serve our new modals config pages ae3b089
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016
@MFlyer MFlyer #1278 - Updated router.js - removed comments & indentation afacdf5
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016
@MFlyer MFlyer #1278 - Added modal window in services.jst template + indentation d0a351e
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016
@MFlyer MFlyer Fixes #1278 - Modified configuration templates for all services havin…
…g one, now better fit on modal - ready to merge/review
fd029aa
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 26, 2016
@MFlyer MFlyer #1278 - Moved loading indicator z-index to 10k, granting it always ov…
…er any modal window
add12c8
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016
@MFlyer MFlyer #1278 - Init commit over modal config - Grant on modal get hidden app…
…router goes back to services
574fcc4
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016
@MFlyer MFlyer #1278 - Changed configure_services view - On submit successful or for…
…m cancel we go back to services hiding modal window
c23ffe1
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016
@MFlyer MFlyer #1278 - Changed configure_services view - Indentation 830abd7
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016
@MFlyer MFlyer #1278 - Updated router.js to serve our new modals config pages 264905e
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016
@MFlyer MFlyer #1278 - Updated router.js - removed comments & indentation 6ed1e21
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016
@MFlyer MFlyer #1278 - Added modal window in services.jst template + indentation f50b095
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016
@MFlyer MFlyer Fixes #1278 - Modified configuration templates for all services havin…
…g one, now better fit on modal - ready to merge/review
12e863d
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 13, 2016
@MFlyer MFlyer #1278 - Moved loading indicator z-index to 10k, granting it always ov…
…er any modal window
8091316
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 15, 2016
@MFlyer MFlyer #1278 - Init commit over modal config - Grant on modal get hidden app…
…router goes back to services
65da330
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 15, 2016
@MFlyer MFlyer #1278 - Changed configure_services view - On submit successful or for…
…m cancel we go back to services hiding modal window
563f0d8
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 15, 2016
@MFlyer MFlyer #1278 - Changed configure_services view - Indentation 3e34bf4
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 15, 2016
@MFlyer MFlyer #1278 - Added modal window in services.jst template + indentation 6270f61
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 15, 2016
@MFlyer MFlyer #1278 - Moved loading indicator z-index to 10k, granting it always ov…
…er any modal window
b284e5b
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 16, 2016
@MFlyer MFlyer #1278 #1529 Firefox no element found related to bad dataType on ajax …
…request, DRF returns html not json

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
0e74912
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 16, 2016
@MFlyer MFlyer #1278 #1529 Move modal div to an higher level outside of maincontent,…
… getting cleaned and refilled on every new socket data received

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
b2e745f
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 16, 2016
@MFlyer MFlyer #1278 #1529 Cleaned services.js view, function handling modal hiding …
…moved to upper level

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
aaf22e8
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 16, 2016
@MFlyer MFlyer Ref to #1278 and Fixes #1529 too
configureService func now doesn't cleanup (we're not moving to a new page anymore)
Check detailed explanation over router.js
Binding modal getting hidden moved here from services.js view (all up from view to upper level)

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
bc767bb
@schakrava schakrava pushed a commit that closed this issue Nov 17, 2016
@MFlyer MFlyer Fixes #1278 - Modified configuration templates for all services havin…
…g one, now better fit on modal - ready to merge/review
2a1cbfb
@schakrava schakrava closed this in 2a1cbfb Nov 17, 2016
@schakrava schakrava assigned MFlyer and unassigned priyaganti Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment