Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.8-13.04 update caused network widget on dashboard to not work #1302

Closed
barnhill opened this Issue Apr 29, 2016 · 23 comments

Comments

Projects
None yet
3 participants
@barnhill
Copy link

barnhill commented Apr 29, 2016

Widget used to show network traffic does not work after the 3.8-13.04 upgrade

@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented Apr 29, 2016

Hi @barnhill can you post a screenshot and/or browser console logs??

thanks

@phillxnet

This comment has been minimized.

Copy link
Member

phillxnet commented Apr 29, 2016

@barnhill Thanks for reporting this; however I think this is a duplicate of #1289 where we already have a little investigation and a more accurate starting point for the occurrence of the issue.
@MFlyer Do you agree? In which case then maybe one or the other should be closed and all info copied into the remaining issue, ie version numbers / findings etc. A small and hopefully relevant console log excerpt is available in the referenced issue.

@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented Apr 29, 2016

Hi @phillxnet , totally agree with you - didn't remember about that issue.

@barnhill can you please close this issue and referer to the other one (as told by @phillxnet on the other side we already have more infos to start with)

Flyer

@barnhill

This comment has been minimized.

Copy link
Author

barnhill commented Apr 29, 2016

I had the previous version and it worked just fine. Any ideas on how that would be possible?

@phillxnet

This comment has been minimized.

Copy link
Member

phillxnet commented Apr 29, 2016

@barnhill As far as I was aware this network widget broken issue started at 3.8-12.13 hence my suspicion this was a duplicate. Are you saying all was well with your install on 3.8-13.03 (the previous version to 3.8-13.04? When ever you update it will jump to what ever is the newest version in the updates channel you are subscribed to. Could you have jumped a few versions?

I have so far assumed that the widget was broken by #1253 as directly after that pr was when I first noticed this and opened the referenced issue.

@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented May 9, 2016

Hi all @phillxnet and @barnhill , done some checking over network widget and found why actually not working:

On #1253 @schakrava added storageadmin.networkconnection over storageadmin.networkdevice (every connection is done over 1 or more devices - teaming/bonding or single device connection, as it was before update), meanwhile network widget still collects initial data from smart_manager_netstat that actually is empty.
Widget view js file has first data grabbing over func getInitialData that ask for /api/sm/sprobes/netstat/?format=json&page_size=1 giving empty results array, so while updating data (every sec) js pushes to dataBuffers being empty/without references for interfaces.

To @schakrava : if you can handle .py side of netstat class i can work on view side 😄 ( getData too -> this.t2 = new Date(data.results[0].ts) works only after setting management interface on rockstor service, before that has to be this.t2 = new Date(data.results[0]['ts']) because results returns an array and each element contains a dictionary, so you have to reference by key) and results[0] is "lo" interface

Flyer

@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented May 9, 2016

After some checks, data.results[0].ts get broken because of missing data, but if we fix it that gets ok

@schakrava Looking to this commit -> d3aa68e if we move to NetworkDeviceCollection instead of NetworkConnectionCollection Network widget works fine (reads data for every device and not for "connection object" that actually i suppose to be a "Rockstor naming convention")

Finally i think it's a big misunderstanding related to names:
My eth0 device is on eth0 connection (but on sys side that is always eth0 device)
Meanwhile a bond0 connection would refer to a bond0 device (made of eth0 and eth1 devices that should not be visible in proc/net/dev because slaves of bond and no more directly exposed)

Obviously while testing i kicked out myself from web ui and ssh too...s@!$? 👎

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue May 9, 2016

rockstor#1302 rockstor#1289 Moved to NetworkDeviceCollection from Net…
…workConnectionCollection that doesn't point to sys devices - bond/team interface should always be under sys devices as expected

@MFlyer MFlyer referenced this issue May 9, 2016

Closed

#1302 #1289 #1311

@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented May 9, 2016

Back again with my Rockstor env up after a stupid test (added ethx with auto without having a nic so got a conflict over eth0 and mess for ips), now we can play (vm snapshot taken!!): @phillxnet as told in PR, do you have 2 avail nics to test if once joined over a team/bond they appear on devices??

My experience: we should have 3 devices (bond0, eth0 slave and eth1 slave, all giving info about current traffic)

@phillxnet

This comment has been minimized.

Copy link
Member

phillxnet commented May 9, 2016

@MFlyer Will have such a setup shortly but as indicated in my comment on the pr it will take a little longer at this end than I would like I'm afraid.

@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented May 9, 2016

Hi @phillxnet not a problem, Proxmox allows me to do "stupid things" like having 3 nics with just one nic so I've tested 😝 (eth0 let me be always inside web ui without kicking me out, eth1 and eth2 for bond/team testing)

What I've done (maybe we need to better explain bond/teaming creation):

  • add eth1 connection like ethernet
  • add eth2 connection like ethernet
  • add bond0 connection with members eth1 and eth2 connections (not devices, important!)
  • Rockstor auto shutdown eth1 and eth2 connections, while waking bond0 (great!! @schakrava 😎, that's a kind of "protection system" to avoid user accidentally kicked out while eths down in favor of bond!)
  • Delete eth1 and eth2 connections

As i expected NetworkDeviceCollection works properly and shows us all devices: lo, eth0, bond0, eth1 and eth2, cos bond0 is the master connection, but eth1 and eth2 are still net devices (bond0 data right, differs from eth1 and eth2)

So finally, I think my PR solves it in the right way (if we don't want to show bond/team slaves then we have to code and filter on js side...but actually network widget - my point of view - correctly reflects system data)

@barnhill

This comment has been minimized.

Copy link
Author

barnhill commented May 21, 2016

This still isnt fixed. in 3.8-13.11

@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented May 21, 2016

Hi @barnhill , you're right saying that hasn't been fixed with 3.8-13.11:
while it seems ok under chrome/chromium, there are some problems over firefox (Check last part of pull request discussion -> #1311 (comment))
Hope to solve asap 😊

@barnhill

This comment has been minimized.

Copy link
Author

barnhill commented May 21, 2016

I'm using chrome and its not ok

Brad Barnhill
bradbarnhill@hotmail.com
On May 21, 2016 1:37 PM, "Mirko Arena" notifications@github.com wrote:

Hi @barnhill https://github.com/barnhill , you're right saying that
hasn't been fixed with 3.8-13.11:
while it seems ok under chrome/chromium, there are some problems over
firefox (Check pull requeste last part -> #1311 (comment)
#1311 (comment)
)
Hope to solve asap 😊


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1302 (comment)

@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented May 21, 2016

I'm using chrome and its not ok
Brad Barnhill

??? Have you manually changed this -> 33b2d1a and built static to test??

@barnhill

This comment has been minimized.

Copy link
Author

barnhill commented May 22, 2016

Nah

Brad Barnhill
bradbarnhill@hotmail.com
On May 21, 2016 3:40 PM, "Mirko Arena" notifications@github.com wrote:

I'm using chrome and its not ok
Brad Barnhill

??? Have you manually changed this -> 33b2d1a
33b2d1a
and built static to test??


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1302 (comment)

@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented May 22, 2016

Ok, so you're still running without any patch. Right it's not solved

@barnhill

This comment has been minimized.

Copy link
Author

barnhill commented May 22, 2016

Right no patch

Brad Barnhill
bradbarnhill@hotmail.com
On May 22, 2016 2:22 AM, "Mirko Arena" notifications@github.com wrote:

Ok, so you're still running without any patch. Right it's not solved


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1302 (comment)

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue May 23, 2016

rockstor#1302 rockstor#1289 - data_collector: added isoformat() to ut…
…c dates to move for example from 2016-05-23 09:46:21.821559+00:00 to 2016-05-23T09:46:21.821559+00:00 - Firefox and Safari don't handle utc dates without T @schakrava

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue May 23, 2016

rockstor#1302 rockstor#1289 - data_collector: added isoformat() to ut…
…c dates to move for example from 2016-05-23 09:46:21.821559+00:00 to 2016-05-23T09:46:21.821559+00:00 - Firefox and Safari don't handle utc dates without T @schakrava

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue May 23, 2016

rockstor#1302 rockstor#1289 - network widget mod to collect device co…
…llection and not connection collection

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue May 23, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue May 23, 2016

rockstor#1302 rockstor#1289 - Added data_collector control for networ…
…k widget - on first run results length = 0 so we avoid to emit and consequent error with data.results[0].ts undefined
@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented Jun 3, 2016

To @schakrava : issue to be closed

@barnhill

This comment has been minimized.

Copy link
Author

barnhill commented Jun 4, 2016

So it's being closed cause it's fixed? In the latest 3.8-13.13 its still not working.

@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented Jun 4, 2016

So it's being closed cause it's fixed? In the latest 3.8-13.13 its still not working

Hi @barnhill , this will be closed because over pull request #1323 got solved (already merged into Rockstor, not available on 3.8-13.13, probably on next release 😃 )

@barnhill

This comment has been minimized.

Copy link
Author

barnhill commented Jun 4, 2016

Oh okay ... sounds good!! Thanks for getting it fixed.

Brad Barnhill
bradbarnhill@hotmail.com
On Jun 4, 2016 4:03 AM, "Mirko Arena" notifications@github.com wrote:

So it's being closed cause it's fixed? In the latest 3.8-13.13 its still
not working

Hi @barnhill https://github.com/barnhill , this will be closed because
over pull request #1323
#1323 got solved (already
merged into Rockstor, not available on 3.8-13.13, probably on next release
😃 )


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1302 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADstDpDdxkjHe7dvIP66ZzZwWMvkjF5Qks5qIT9QgaJpZM4ISgBc
.

@MFlyer

This comment has been minimized.

Copy link
Member

MFlyer commented Jun 13, 2016

Hi @barnhill , now on 3.8-13.14 issue has been fixed 😄

Flyer

P.S.: @schakrava or @barnhill - Issue to be closed

@barnhill

This comment has been minimized.

Copy link
Author

barnhill commented Jun 19, 2016

Just updated to 3.8-13.18 and now its fixed. As of 17 it was still broken but 18 fixed it on my machine. Thanks.

@barnhill barnhill closed this Jun 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.