New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful shutdown with cron job #1306

Closed
gkellar opened this Issue May 5, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@gkellar

gkellar commented May 5, 2016

I am trying to schedule rockstor to shutdown at 4:00 a.m. every morning. I currently use a cronjob: "shutdown -h now
The machine shuts down on schedule but randomly does not shutdown gracefully. In particular, randomly, after shutting down, it will not restart properly. A forced restart at that point will correct the situation. How can I "gracefully" shut down rockstor at a set time?
Thanks in advance

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer May 5, 2016

Member

Hi @gkellar, actually Rockstor doesn't have a "cron manager" for tasks different from web ui tasks (snapshots, scrub and replica) - We'll add a cron manager asap because it's a useful feature requested by other users too

Actually Rockstor web ui shutdown = shutdown -h now, so that should be ok

Flyer

Member

MFlyer commented May 5, 2016

Hi @gkellar, actually Rockstor doesn't have a "cron manager" for tasks different from web ui tasks (snapshots, scrub and replica) - We'll add a cron manager asap because it's a useful feature requested by other users too

Actually Rockstor web ui shutdown = shutdown -h now, so that should be ok

Flyer

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet May 7, 2016

Member

@gkellar @MFlyer I have seen Rockstor's shutdown, which as @MFlyer points out is simply a "shutdown -h now", hang at a very late stage but only when installed on USB, when the same hw was used but with a non USB boot device this occasional failure to fully shutdown was no longer observed.
I put this down to being related to the current upstream kernel issues re USB system drives.
@roweryan looked into the kernel USB issue and reported on this in comments within the following issue:- #1069
see post dated 31st Jan. Apparently this is now sorted in kernel versions >= 4.5.0.

My own experience of non clean shutdowns ie no actual power off due to kernel panic or unmount issues were with Rockstor installed on SanDisk Extreme USB 3.0 32GB.

Linking to our open issue for "Custom Cron Jobs via WebGUI":
#1036
to show the additional interest.

Member

phillxnet commented May 7, 2016

@gkellar @MFlyer I have seen Rockstor's shutdown, which as @MFlyer points out is simply a "shutdown -h now", hang at a very late stage but only when installed on USB, when the same hw was used but with a non USB boot device this occasional failure to fully shutdown was no longer observed.
I put this down to being related to the current upstream kernel issues re USB system drives.
@roweryan looked into the kernel USB issue and reported on this in comments within the following issue:- #1069
see post dated 31st Jan. Apparently this is now sorted in kernel versions >= 4.5.0.

My own experience of non clean shutdowns ie no actual power off due to kernel panic or unmount issues were with Rockstor installed on SanDisk Extreme USB 3.0 32GB.

Linking to our open issue for "Custom Cron Jobs via WebGUI":
#1036
to show the additional interest.

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jul 17, 2016

Dive into tasks land for #735 #1036 #1306
Initial commit for custome scheduled tasks feature on Rockstor

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jul 19, 2016

Dive into tasks land for #735 #1036 #1306
Initial commit for custome scheduled tasks feature on Rockstor

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Sep 30, 2016

Dive into tasks land for #735 #1036 #1306
Initial commit for custome scheduled tasks feature on Rockstor

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 2, 2016

Dive into tasks land for #735 #1036 #1306
Initial commit for custome scheduled tasks feature on Rockstor

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Oct 7, 2016

Dive into tasks land for #735 #1036 #1306
Initial commit for custome scheduled tasks feature on Rockstor

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 15, 2016

Dive into tasks land for #735 #1036 #1306
Initial commit for custome scheduled tasks feature on Rockstor

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 16, 2017

#735 #1306 adding init commit, defining reboot task type
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 16, 2017

System/osi reboot and shutdown refactoring
Refs to #735 and #1306 - reboot and shutdown funcs already used
when performing those action via WebUI. Scheduled reboots/shutdowns
will have a 2 min delay (shutdown now is instead 1 min) to allow
users to stop system shutdown too

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 16, 2017

Reboot and Shutdown tasks - adding url dispatcher and view params
Refs to #735 and #1306 - Url Dispatcher updated to handle new
reboot/shutdown delay param, same done over commands view
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 19, 2017

RTC System Wake up custom fields
Refs to #735 #1306 - Adding rtc wake up hour and minute fields to
shutdown template plus auto toggle on rtc wake up checkbox

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 21, 2017

Adding System Suspend task
Refs to #735 #1306 and #1036 - Adding new suspend task on backend model
and view plus smart_manager migration patching
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 21, 2017

Adding Suspend task support on frontend
Refs to #735 #1306 #1036: If task is suspend, aka system suspend
to RAM, we force users to have a wake up!
Adding suspend too because probably many system won't support
full power off + wake, while suspend works

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 21, 2017

Adding System suspend to url dispatcher and command view
Refs to #735 #1306 #1036
Delay param for reboot and shutdown no more required, checking if
scheduled task via request.auth (none if command from WebUI, token if
over APIWrapper by scheduled task). When shutdown and reboot come from
a scheduled task we grant a 3 minute grace period to cancel it
New rtcepoch param used to pass desired system wakeup epoch for
shutdown and suspend
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 21, 2017

Task scheduler enhancements to wakeup system and adds to handle suspend
Refs to #735 #1306 #1036
Added new handler for suspend task, served by same script.
Wakeup need rtc hour/minute int to compute if task will be this day or
next day, data conversion here to avoid it over cron script, so we convert
from string to int only on db saving.

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 21, 2017

reboot-shutdown-suspend script rewrite
Refs to #735 #1306 #1036
APIWrapper no more sending delay, using instead epoch wakeup time
if present (delay checks moved to command view with token/not token req check)
On shutdown and suspend tasks we check if wakeup option is on and parse
cron time vs wakeup time to find if wake is on same day or next day

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 21, 2017

osi functions enhancements and adds
Refs to #735 #1306 #1036
system_shutdown and system_reboot run with a delta, default to now when
running from user input from WebUi and 3 mins when called via scheduled tasks
Added system_suspend function just running a systemctl suspend
Added wakeup functions set_system_rtc_wake and clean_system_rtc_wake:
set_system_rtc_wake is our core function to set system wakeup, writing to default
rtc0 wakealarm user wakeup time in epoch format, after flushing every wakeup value
with clean_system_rtc_wake (write 0 to clean every time or we raise a resurce busy err)
IMPORTANT: epoch can't be passed as a string, needed int -> write('%s' % epoch) fails

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 24, 2017

Adding new filter over task tyep
Refs to #735 #1306 #1036 - Added new else statement over tasks list page
to handle common tasks like shutdown, suspend and reboot

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 27, 2017

Models.js mods to add wakeup fields
Refs to #735 #1306 #1036 - Added new wakeup, rtc_hour and rtc_minute
fields to backbone properties for Task object

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 27, 2017

Scheduled tasks templates and views cleaning
Refs to #735 #1306 #1036 - Cleaned template structure
Before this commit we had a page with 2 templates (main template and
optional-fields template), "child" optional-fields template was used
only when creating new tasks, tasks edit had a messy if else group on
main template -> Moved all to optional-fields rendering on edit too

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 27, 2017

Templates and views reordering
Refs to #735 #1306 #1036
Scheduling task has a complete new view handling tasks edit over
optional-fields template instead of main template
Added some helpers (jquery helpers and Handlebars Helpers) for new
shutdown/suspend/reboot tasks plus Handlebars Partials to have global
vars to make taskObj available to main template and optional-fields
template to. @schakrava check inline comments for more infos ;)

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 27, 2017

Python PEP8
Refs #735 #1306 #1036 - Flake8 for some files

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

#735 #1306 adding init commit, defining reboot task type
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

System/osi reboot and shutdown refactoring
Refs to #735 and #1306 - reboot and shutdown funcs already used
when performing those action via WebUI. Scheduled reboots/shutdowns
will have a 2 min delay (shutdown now is instead 1 min) to allow
users to stop system shutdown too

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Reboot and Shutdown tasks - adding url dispatcher and view params
Refs to #735 and #1306 - Url Dispatcher updated to handle new
reboot/shutdown delay param, same done over commands view
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

RTC System Wake up custom fields
Refs to #735 #1306 - Adding rtc wake up hour and minute fields to
shutdown template plus auto toggle on rtc wake up checkbox

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Adding System Suspend task
Refs to #735 #1306 and #1036 - Adding new suspend task on backend model
and view plus smart_manager migration patching
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Adding Suspend task support on frontend
Refs to #735 #1306 #1036: If task is suspend, aka system suspend
to RAM, we force users to have a wake up!
Adding suspend too because probably many system won't support
full power off + wake, while suspend works

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Adding System suspend to url dispatcher and command view
Refs to #735 #1306 #1036
Delay param for reboot and shutdown no more required, checking if
scheduled task via request.auth (none if command from WebUI, token if
over APIWrapper by scheduled task). When shutdown and reboot come from
a scheduled task we grant a 3 minute grace period to cancel it
New rtcepoch param used to pass desired system wakeup epoch for
shutdown and suspend
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Task scheduler enhancements to wakeup system and adds to handle suspend
Refs to #735 #1306 #1036
Added new handler for suspend task, served by same script.
Wakeup need rtc hour/minute int to compute if task will be this day or
next day, data conversion here to avoid it over cron script, so we convert
from string to int only on db saving.

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

reboot-shutdown-suspend script rewrite
Refs to #735 #1306 #1036
APIWrapper no more sending delay, using instead epoch wakeup time
if present (delay checks moved to command view with token/not token req check)
On shutdown and suspend tasks we check if wakeup option is on and parse
cron time vs wakeup time to find if wake is on same day or next day

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

osi functions enhancements and adds
Refs to #735 #1306 #1036
system_shutdown and system_reboot run with a delta, default to now when
running from user input from WebUi and 3 mins when called via scheduled tasks
Added system_suspend function just running a systemctl suspend
Added wakeup functions set_system_rtc_wake and clean_system_rtc_wake:
set_system_rtc_wake is our core function to set system wakeup, writing to default
rtc0 wakealarm user wakeup time in epoch format, after flushing every wakeup value
with clean_system_rtc_wake (write 0 to clean every time or we raise a resurce busy err)
IMPORTANT: epoch can't be passed as a string, needed int -> write('%s' % epoch) fails

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Adding new filter over task tyep
Refs to #735 #1306 #1036 - Added new else statement over tasks list page
to handle common tasks like shutdown, suspend and reboot

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Models.js mods to add wakeup fields
Refs to #735 #1306 #1036 - Added new wakeup, rtc_hour and rtc_minute
fields to backbone properties for Task object

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Scheduled tasks templates and views cleaning
Refs to #735 #1306 #1036 - Cleaned template structure
Before this commit we had a page with 2 templates (main template and
optional-fields template), "child" optional-fields template was used
only when creating new tasks, tasks edit had a messy if else group on
main template -> Moved all to optional-fields rendering on edit too

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Templates and views reordering
Refs to #735 #1306 #1036
Scheduling task has a complete new view handling tasks edit over
optional-fields template instead of main template
Added some helpers (jquery helpers and Handlebars Helpers) for new
shutdown/suspend/reboot tasks plus Handlebars Partials to have global
vars to make taskObj available to main template and optional-fields
template to. @schakrava check inline comments for more infos ;)

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Python PEP8
Refs #735 #1306 #1036 - Flake8 for some files

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Javascript code rebase and linting
Refs to #735 #1306 #1036

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 28, 2017

Second linting session (hand linting)
Refs #735 #1306 #1036

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 2, 2017

Adding warning for RTC WAKEUP capabiliets
Refs to #735 #1306 #1036 - Added user warning to check/test RTC WAKEUP capabilities
before setting a shutdown/suspend task

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 3, 2017

Adding new task types to task logs page
Refs to #735 #1306 #1036
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 4, 2017

Adding Shutdown/Reboot tasks layout alerts elements
Refs #735 #1306 #1036 - Added ad hoc div to alert user about scheduled
shutdown/reboot task
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 4, 2017

Adding systemd-shutdownd service
Refs to #735 #1306 #1036 - Added systemd-shutdownd service to available services
for monitoring. Service turns on (rc=0) when a system shutdown/reboot scheduled,
turns off (rc=3) if no shutdowns scheduled

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 4, 2017

Adding new Socket.io handler for system shutdown/reboot checks
Refs to #735 #1306 #1036 - frontend/backend adds to control pending
shutdown/reboot tasks. data_collector checks every 30 secs if we have
a pending shutdown (if scheduled returns shutdown message with time infos too)
On fronted we alert user with a message over Rockstor navbar

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

#735 #1306 adding init commit, defining reboot task type
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

System/osi reboot and shutdown refactoring
Refs to #735 and #1306 - reboot and shutdown funcs already used
when performing those action via WebUI. Scheduled reboots/shutdowns
will have a 2 min delay (shutdown now is instead 1 min) to allow
users to stop system shutdown too

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Reboot and Shutdown tasks - adding url dispatcher and view params
Refs to #735 and #1306 - Url Dispatcher updated to handle new
reboot/shutdown delay param, same done over commands view
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

RTC System Wake up custom fields
Refs to #735 #1306 - Adding rtc wake up hour and minute fields to
shutdown template plus auto toggle on rtc wake up checkbox

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Adding System Suspend task
Refs to #735 #1306 and #1036 - Adding new suspend task on backend model
and view plus smart_manager migration patching
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Adding Suspend task support on frontend
Refs to #735 #1306 #1036: If task is suspend, aka system suspend
to RAM, we force users to have a wake up!
Adding suspend too because probably many system won't support
full power off + wake, while suspend works

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Adding System suspend to url dispatcher and command view
Refs to #735 #1306 #1036
Delay param for reboot and shutdown no more required, checking if
scheduled task via request.auth (none if command from WebUI, token if
over APIWrapper by scheduled task). When shutdown and reboot come from
a scheduled task we grant a 3 minute grace period to cancel it
New rtcepoch param used to pass desired system wakeup epoch for
shutdown and suspend
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Task scheduler enhancements to wakeup system and adds to handle suspend
Refs to #735 #1306 #1036
Added new handler for suspend task, served by same script.
Wakeup need rtc hour/minute int to compute if task will be this day or
next day, data conversion here to avoid it over cron script, so we convert
from string to int only on db saving.

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

reboot-shutdown-suspend script rewrite
Refs to #735 #1306 #1036
APIWrapper no more sending delay, using instead epoch wakeup time
if present (delay checks moved to command view with token/not token req check)
On shutdown and suspend tasks we check if wakeup option is on and parse
cron time vs wakeup time to find if wake is on same day or next day

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

osi functions enhancements and adds
Refs to #735 #1306 #1036
system_shutdown and system_reboot run with a delta, default to now when
running from user input from WebUi and 3 mins when called via scheduled tasks
Added system_suspend function just running a systemctl suspend
Added wakeup functions set_system_rtc_wake and clean_system_rtc_wake:
set_system_rtc_wake is our core function to set system wakeup, writing to default
rtc0 wakealarm user wakeup time in epoch format, after flushing every wakeup value
with clean_system_rtc_wake (write 0 to clean every time or we raise a resurce busy err)
IMPORTANT: epoch can't be passed as a string, needed int -> write('%s' % epoch) fails

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Adding new filter over task tyep
Refs to #735 #1306 #1036 - Added new else statement over tasks list page
to handle common tasks like shutdown, suspend and reboot

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Models.js mods to add wakeup fields
Refs to #735 #1306 #1036 - Added new wakeup, rtc_hour and rtc_minute
fields to backbone properties for Task object

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Scheduled tasks templates and views cleaning
Refs to #735 #1306 #1036 - Cleaned template structure
Before this commit we had a page with 2 templates (main template and
optional-fields template), "child" optional-fields template was used
only when creating new tasks, tasks edit had a messy if else group on
main template -> Moved all to optional-fields rendering on edit too

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Templates and views reordering
Refs to #735 #1306 #1036
Scheduling task has a complete new view handling tasks edit over
optional-fields template instead of main template
Added some helpers (jquery helpers and Handlebars Helpers) for new
shutdown/suspend/reboot tasks plus Handlebars Partials to have global
vars to make taskObj available to main template and optional-fields
template to. @schakrava check inline comments for more infos ;)

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Python PEP8
Refs #735 #1306 #1036 - Flake8 for some files

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Javascript code rebase and linting
Refs to #735 #1306 #1036

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Second linting session (hand linting)
Refs #735 #1306 #1036

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Adding warning for RTC WAKEUP capabiliets
Refs to #735 #1306 #1036 - Added user warning to check/test RTC WAKEUP capabilities
before setting a shutdown/suspend task

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Adding new task types to task logs page
Refs to #735 #1306 #1036
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Adding Shutdown/Reboot tasks layout alerts elements
Refs #735 #1306 #1036 - Added ad hoc div to alert user about scheduled
shutdown/reboot task
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Adding systemd-shutdownd service
Refs to #735 #1306 #1036 - Added systemd-shutdownd service to available services
for monitoring. Service turns on (rc=0) when a system shutdown/reboot scheduled,
turns off (rc=3) if no shutdowns scheduled

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 8, 2017

Adding new Socket.io handler for system shutdown/reboot checks
Refs to #735 #1306 #1036 - frontend/backend adds to control pending
shutdown/reboot tasks. data_collector checks every 30 secs if we have
a pending shutdown (if scheduled returns shutdown message with time infos too)
On fronted we alert user with a message over Rockstor navbar

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Mar 23, 2017

Member

To @schakrava : this can be closed, missing "Fixes" statement over recent PR

Mirko

Member

MFlyer commented Mar 23, 2017

To @schakrava : this can be closed, missing "Fixes" statement over recent PR

Mirko

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava Mar 24, 2017

Member

Nice work on this @MFlyer . Thank you!

Member

schakrava commented Mar 24, 2017

Nice work on this @MFlyer . Thank you!

@schakrava schakrava closed this Mar 24, 2017

@schakrava schakrava added this to the Point Bonita milestone Mar 24, 2017

@schakrava schakrava changed the title from graceful shutdown with cron job to Graceful shutdown with cron job Jul 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment