New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve dashboard disk activity widget for by-id names #1366

Closed
phillxnet opened this Issue Jul 5, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@phillxnet
Member

phillxnet commented Jul 5, 2016

As from version 3.8-14.02 testing updates the new by-id names are frequently overlapping in the dashboard disk activity widget as they are much longer that the temp names used previously. There are a number of trivial changes that can be applied to this widget that should help with this issue, at least for the time being, including making better use of the available width.

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Jul 5, 2016

Member

I am having a quick look at this now as with a few simple tweaks we should be able to reduce the name overlap such that at least in the maximised state, drive identification info should still be usable.

Member

phillxnet commented Jul 5, 2016

I am having a quick look at this now as with a few simple tweaks we should be able to reduce the name overlap such that at least in the maximised state, drive identification info should still be usable.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 5, 2016

increase default and maximized width of disk bar #1366
Previously this bar did not use the entire width of the widget.
These values appear to leave roughly equal margins to the
left and right of the bar.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 5, 2016

remove redundant text percentage indicator #1366
As we are displaying graphically the relative activity
across all disks the individual percentage in text by
every disk name is redundant and costly in what is now
a very tight space. Better to have this space available
for naming options to identify the drive / drives indicated.
@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Jul 5, 2016

Member

By loosing the text percentage indicator by each name we typically gain 9 characters per disk name.
Device serial numbers are often around 15 characters so as a typical temp_name = 3 characters and with prior percentage indicator we had 12 characters per device so we may for the time being restore something akin to previous text density by using just the serial component of the by-id name, especially since our Top Disk bar is now using more of the previously unused widget width.

Member

phillxnet commented Jul 5, 2016

By loosing the text percentage indicator by each name we typically gain 9 characters per disk name.
Device serial numbers are often around 15 characters so as a typical temp_name = 3 characters and with prior percentage indicator we had 12 characters per device so we may for the time being restore something akin to previous text density by using just the serial component of the by-id name, especially since our Top Disk bar is now using more of the previously unused widget width.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 5, 2016

use only the serial part of the by-id name in widget #1366
As we are short on text space divide up the by-id
name and use only it's serial component. This servers
to both uniquely identify the associated disk and drastically
reduce the text length.
@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Jul 5, 2016

Member

With the above changes we have a more workable readout while still maintaining the ability to identify disks individually. The arrangement is of course limited as if a disk's activity represents a small percentage of may disk then it will of couse have a very small space in which to display it's id but at least these changes mostly address the regression introduced by #1357.

Member

phillxnet commented Jul 5, 2016

With the above changes we have a more workable readout while still maintaining the ability to identify disks individually. The arrangement is of course limited as if a disk's activity represents a small percentage of may disk then it will of couse have a very small space in which to display it's id but at least these changes mostly address the regression introduced by #1357.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 5, 2016

set disk bar width on resize to match initial widget setting #1366
This should probably be held in a widget variable to avoid becoming
out of sync. Also trivial rogue tab replacement with spaces.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 5, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 5, 2016

alter number of top disks displayed according to widget size #1366
Previously we displayed the top 5 disks irrespective of widget
size. This moves to a dynamic setting for the number of top
disks displayed: 5 as before when maximised and 3 when not.

@schakrava schakrava closed this in a395939 Sep 30, 2016

@schakrava schakrava added this to the Looney Bean milestone Sep 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment