New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Services page bottleneck on Active Directory status #1391

Closed
MFlyer opened this Issue Jul 12, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@MFlyer
Member

MFlyer commented Jul 12, 2016

Hi @schakrava ,
while looking again to services page loading i asked myself why it's slower then others so performed some checks on base_service page and found out this:

[12/Jul/2016 14:37:50] DEBUG [smart_manager.views.base_service:86] Sorting for Rockstor
[12/Jul/2016 14:37:50] DEBUG [smart_manager.views.base_service:86] Sorting for S.M.A.R.T
[12/Jul/2016 14:37:50] DEBUG [smart_manager.views.base_service:86] Sorting for Samba
[12/Jul/2016 14:37:50] DEBUG [smart_manager.views.base_service:86] Sorting for Active Directory <--
[12/Jul/2016 14:38:03] DEBUG [smart_manager.views.base_service:86] Sorting for NTP
[12/Jul/2016 14:38:03] DEBUG [smart_manager.views.base_service:86] Sorting for NUT-UPS
[12/Jul/2016 14:38:03] DEBUG [smart_manager.views.base_service:86] Sorting for SNMP
[12/Jul/2016 14:38:03] DEBUG [smart_manager.views.base_service:86] Sorting for SFTP
[12/Jul/2016 14:38:04] DEBUG [smart_manager.views.base_service:86] Sorting for Rock-on
[12/Jul/2016 14:38:04] DEBUG [smart_manager.views.base_service:86] Sorting for Replication
[12/Jul/2016 14:38:04] DEBUG [smart_manager.views.base_service:86] Sorting for Shell In A Box
[12/Jul/2016 14:38:04] DEBUG [smart_manager.views.base_service:86] Sorting for NFS
[12/Jul/2016 14:38:04] DEBUG [smart_manager.views.base_service:86] Sorting for LDAP
[12/Jul/2016 14:38:04] DEBUG [smart_manager.views.base_service:86] Sorting for NIS
[12/Jul/2016 14:38:04] DEBUG [smart_manager.views.base_service:86] Sorting for AFP
[12/Jul/2016 14:38:04] DEBUG [smart_manager.views.base_service:86] Sorting for ZTaskd
[12/Jul/2016 14:38:04] DEBUG [smart_manager.views.base_service:86] Sorting for Bootstrap

As you can see checking Active Directory status (net ads status) is our bottleneck so here my suggestion: avoid initial status check on collection.fecth because it's a kind of repetition with next listener from socket.io services (collect services status on first run, add socket.io listener and get statuses again: we can skip first check to immediately render page)

What do you think about this?

Flyer

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Jul 15, 2016

Member

Suggestion: with net ads status -U domain/Admin we get full info about domain and this is why this get too long. We should instead just try with a net ads testjoin (eventually plus a wbinfo -t -D domain_name) and this get faster @schakrava

Member

MFlyer commented Jul 15, 2016

Suggestion: with net ads status -U domain/Admin we get full info about domain and this is why this get too long. We should instead just try with a net ads testjoin (eventually plus a wbinfo -t -D domain_name) and this get faster @schakrava

@schakrava schakrava closed this in 44a332b Jul 22, 2016

schakrava added a commit that referenced this issue Jul 22, 2016

Merge pull request #1395 from MFlyer/issue#1391_Active_Directory_Bott…
…leneck_On_Services_Page

Fixes #1391 - Changed how we check Active Directory status

@schakrava schakrava changed the title from Services page bottleneck on Active Directory status to Fix Services page bottleneck on Active Directory status Nov 1, 2016

@schakrava schakrava added this to the Looney Bean milestone Nov 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment