New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single pool metadata level is single not dup #1409

Closed
phillxnet opened this Issue Jul 27, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@phillxnet
Member

phillxnet commented Jul 27, 2016

The current default of a single pool metadata level appears to be single also. My understanding was that in the case of single pool creation we intended metadata to default to dup, not single:
https://forum.rockstor.com/t/internal-implementation-of-pools-shares-snapshots-and-clones/453

btrfs fi df /mnt2/single-pool/
Data, single: total=8.00MiB, used=64.00KiB
System, single: total=4.00MiB, used=16.00KiB
Metadata, single: total=248.00MiB, used=128.00KiB
GlobalReserve, single: total=16.00MiB, used=0.00B

Tested on current master branch.

This would also bring our single data pools in line with the rockstor_rockstor single pool profile ie:

btrfs fi df /mnt2/rockstor_rockstor/
Data, single: total=3.37GiB, used=2.71GiB
System, DUP: total=8.00MiB, used=16.00KiB
System, single: total=4.00MiB, used=0.00B
Metadata, DUP: total=471.50MiB, used=165.94MiB
Metadata, single: total=8.00MiB, used=0.00B
GlobalReserve, single: total=64.00MiB, used=0.00B

so single data and dup metadata. It would also provide a more robust default without sacrificing much in the way of space.

Comments?

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava Jul 27, 2016

Member

Hi @phillxnet. dup metadata profile for single pools is a good idea and also recommended by BTRFS. Something we should've changed a while ago. Many thanks for digging it up!

Member

schakrava commented Jul 27, 2016

Hi @phillxnet. dup metadata profile for single pools is a good idea and also recommended by BTRFS. Something we should've changed a while ago. Many thanks for digging it up!

@schakrava schakrava added this to the Pinnacles milestone Jul 27, 2016

@schakrava schakrava closed this in 5f553c8 Mar 28, 2017

schakrava added a commit that referenced this issue Mar 28, 2017

Merge pull request #1681 from schakrava/1409_single_pool_metadata
Set metadata raid = dup for single pools. Fixes #1409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment