New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs unittests part 1 #1443

Closed
phillxnet opened this Issue Sep 23, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@phillxnet
Member

phillxnet commented Sep 23, 2016

Based on and including @schakrava pending fs/btrfs unittest commits in pr #1023, this issue is intended to address my initial commits made to what @schakrava laid out in pr #1023 for issue #1022 (fs unittests setup). The intention is for this issue to be a super set of #1022 to aid in merging and render issue #1022 and pr #1023 redundant by way of inclusion.

As per the above, this issue is essentially a duplicate of #1022 to aid in my splitting unittest code additions out from my outstanding compound pr #1418 (for issue #1405) and improve commit message headers in the process.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

remove deprecated smb config template reference #1443
This reference was previously removed from settings.conf.in
in #1241 so updating the test-settings.conf.in similarly.

(cherry picked from commit 8cbb1d0)

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

assemble test data for get_pool_raid_levels() #1443
As we have an instance of mis-identifying a raid1 due to
rogue but normal single data chunks we need sufficient data to
confirm all raid levels are correctly identified and to avoid a
regression in the future.

(cherry picked from commit 7c30c0c)

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

add test of pool raid level identification #1443
Uses example output from 'btrfs fi df mount_point'
and expected parsing results to test pool raid level
info parsing logic. Includes example of raid1 with
rogue but legitimate single data chunks.

(cherry picked from commit d6f2a3b)

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

remove duplicate import statement #1443
(cherry picked from commit cd4292e)

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

typo causing wrong exception message for raid5 #1443
Also removed unused import statements.

(cherry picked from commit ca51b65)

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

add comments and error logging to add_pool() #1443
Also only try to enable quotas on zero return code from
pool creation command.

(cherry picked from commit 68d1542)

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

add test data for default system pool format #1443
By default the rockstor_rockstor pool is created with
data single and metadata dup.

(cherry picked from commit 60dc380)

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

remark out unit tests requiring target code refactoring #1443
Also use more specific assert commands.

(cherry picked from commit 73a3555)

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

add unit test for share_usage() function #1443
Basic test to confirm mid line parsing capability with mounted
pool and existing share_id / qgroupid.

(cherry picked from commit dd6de0c)

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

remove share_usage() debug logging for issue #1443
Also improve balance_status docstring entries.

(cherry picked from commit d524449)

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

add unit test data for balance_status pausing and paused #1443
Only skeleton test entries to be finished shortly.

(cherry picked from commit 35e370a)

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 23, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 24, 2016

remove debug logging for issue #1443
Repair missed commit in git cherry pick / merge procedure
during pr split prior to merge.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Sep 25, 2016

remove duplicate docstrings and a low value comment #1443
To aid merging with sister pr #1445 which also contains the
same docstrings.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 6, 2016

@schakrava schakrava closed this in #1444 Oct 7, 2016

schakrava added a commit that referenced this issue Oct 7, 2016

@schakrava schakrava added the Testing label Oct 7, 2016

@schakrava schakrava added this to the Looney Bean milestone Oct 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment