Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Systemd warns that "rockstor-hdparm.service is marked world-inaccessible" #1493
As already mentioned before, systemd keeps logging this:
It can easily be fixed manually by executing:
And it makes me feel much better :D
@maxhq Thanks for bringing this up again and nice to have it in an issue of it's own.
From a quick look I think where the rockstor-hdparm.service file is concerned we can apply the required chmod directly after moving the edited temp file over the live file with the following line:
along with a definition for CHMOD at the head of the file.
Previously (in your linked reference) I had thought that this systemd overly restrictive rights warning affected many systemd files but upon looking just now it seems to only affect this one Rockstor created systemd file. Only had a quick look though so if you could confirm this that would be a help.
Do you fancy changing this issue's title to reference this one file if that is also your finding as then I can commit these changes against your issue and have the branch name used be more specific:
Cheers. And yes this would also make me feel at least a little better :D.
@maxhq Do you fancy having a go at this one, since we have pretty much sorted it already in this issue. I can add it to my queue otherwise. Given the relatively harmless nature I don't think we need account for existing file permissions only the newly created. Users can always trivially adjust spin-down times and get the new perms that way.
No worries otherwise as it was my code and my omission so more than happy to get to it but must finish my current run before that.