Move from gevent-socketio python-socketio #1503

Closed
MFlyer opened this Issue Oct 29, 2016 · 2 comments

Projects

None yet

2 participants

@MFlyer
Member
MFlyer commented Oct 29, 2016

Reference to #848,
currently we're deleting flash websockets support (no more required), but gevent-socketio lib seems discontinued, so need to move to another compatible with latest socket.io

Suggestion: https://github.com/miguelgrinberg/python-socketio

M

@MFlyer
Member
MFlyer commented Oct 31, 2016 edited

Hi all,
after some initial testing over python-socketio can safely state we're going to check it over 3.8-16 cycle:
having engine.io = js engine.io this new module forces us to partially rewrite data_collector & all views connecting with socket.io + mods to gunicorn init etc etc

99% going to ask @schakrava help about eggs (six migrating to 1.9, gevent-socketio no more required ok on setup.py, while not yet checked django-hack file)

Other possible alternative: Django Channels -> https://github.com/django/channels (required Django >=1.8)
M.

@MFlyer
Member
MFlyer commented Nov 1, 2016 edited

Got a working python-socketio on Rockstor (testing on sysinfo)

EDIT: Dev is working fine, namespaces & events handling is easier, coding new backend-frontend funcs & finally testing upgrading gevent to latest version too

@MFlyer MFlyer added a commit to MFlyer/rockstor-jslibs that referenced this issue Nov 4, 2016
@MFlyer MFlyer rockstor/rockstor-core#1503 - Added socket.io client 1.5.1 6c92b9d
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016
@MFlyer MFlyer #1503 - Modify nginx conf to connect to new python-socketio server 08469bb
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016
@MFlyer MFlyer #1503 - Update python-django dependencies f43225b
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016
@MFlyer MFlyer #1503 - Update setup.py lic b4c73f3
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016
@MFlyer MFlyer #1503 - Cleaning router.js removing unrequired on event for kernel_er…
…ror - ad hoc func exists -, plus code cleaning
0bf1d8a
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016
@MFlyer MFlyer Socket_listen.js update on #1503
Adding listener to namespace_event instead of namespace:event (not required)
Removing listener (disconnect) now doesn't require socket.disconnect
a0527ca
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016
@MFlyer MFlyer #1503 - Updated all dashboard widgets - hypens/minus not working on n…
…amespaces/events
6762207
@MFlyer MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016
@MFlyer MFlyer #1503 - Updated router.js and socket_listen.js - modified how we hand…
…le new socket.io connections
d016ca1
@MFlyer MFlyer added a commit to MFlyer/rockstor-jslibs that referenced this issue Nov 5, 2016
@MFlyer MFlyer rockstor/rockstor-core#1503 - Added socket.io client 1.5.1map dependency c85231b
@schakrava schakrava added a commit to schakrava/rockstor-core that referenced this issue Nov 15, 2016
@schakrava schakrava update jslibs for socketio. pin python-socketio version. sort. #1503 2580d1a
@schakrava schakrava pushed a commit that closed this issue Nov 15, 2016
@MFlyer MFlyer This finally Fixes #1503 - new data_collector structure with full pyt…
…hon-socketio. Main has IMPORTANT notes for everyone coding new namespaces/events
0283af2
@schakrava schakrava closed this in 0283af2 Nov 15, 2016
@schakrava schakrava added this to the Pinnacles milestone Nov 15, 2016
@MFlyer MFlyer was assigned by schakrava Nov 15, 2016
@schakrava schakrava changed the title from Update gevent-socketio library / Move to a new library to Move from gevent-socketio python-socketio Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment