New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from gevent-socketio python-socketio #1503

Closed
MFlyer opened this Issue Oct 29, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@MFlyer
Member

MFlyer commented Oct 29, 2016

Reference to #848,
currently we're deleting flash websockets support (no more required), but gevent-socketio lib seems discontinued, so need to move to another compatible with latest socket.io

Suggestion: https://github.com/miguelgrinberg/python-socketio

M

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Oct 31, 2016

Member

Hi all,
after some initial testing over python-socketio can safely state we're going to check it over 3.8-16 cycle:
having engine.io = js engine.io this new module forces us to partially rewrite data_collector & all views connecting with socket.io + mods to gunicorn init etc etc

99% going to ask @schakrava help about eggs (six migrating to 1.9, gevent-socketio no more required ok on setup.py, while not yet checked django-hack file)

Other possible alternative: Django Channels -> https://github.com/django/channels (required Django >=1.8)
M.

Member

MFlyer commented Oct 31, 2016

Hi all,
after some initial testing over python-socketio can safely state we're going to check it over 3.8-16 cycle:
having engine.io = js engine.io this new module forces us to partially rewrite data_collector & all views connecting with socket.io + mods to gunicorn init etc etc

99% going to ask @schakrava help about eggs (six migrating to 1.9, gevent-socketio no more required ok on setup.py, while not yet checked django-hack file)

Other possible alternative: Django Channels -> https://github.com/django/channels (required Django >=1.8)
M.

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Nov 1, 2016

Member

Got a working python-socketio on Rockstor (testing on sysinfo)

EDIT: Dev is working fine, namespaces & events handling is easier, coding new backend-frontend funcs & finally testing upgrading gevent to latest version too

Member

MFlyer commented Nov 1, 2016

Got a working python-socketio on Rockstor (testing on sysinfo)

EDIT: Dev is working fine, namespaces & events handling is easier, coding new backend-frontend funcs & finally testing upgrading gevent to latest version too

MFlyer added a commit to MFlyer/rockstor-jslibs that referenced this issue Nov 4, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016

#1503 - Cleaning router.js removing unrequired on event for kernel_er…
…ror - ad hoc func exists -, plus code cleaning

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016

Socket_listen.js update on #1503
Adding listener to namespace_event instead of namespace:event (not required)
Removing listener (disconnect) now doesn't require socket.disconnect

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Nov 5, 2016

MFlyer added a commit to MFlyer/rockstor-jslibs that referenced this issue Nov 5, 2016

schakrava added a commit to rockstor/rockstor-jslibs that referenced this issue Nov 15, 2016

schakrava added a commit to schakrava/rockstor-core that referenced this issue Nov 15, 2016

@schakrava schakrava closed this in 0283af2 Nov 15, 2016

@schakrava schakrava added this to the Pinnacles milestone Nov 15, 2016

@schakrava schakrava changed the title from Update gevent-socketio library / Move to a new library to Move from gevent-socketio python-socketio Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment