New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Samba AD closing line #1548

Closed
MFlyer opened this Issue Nov 28, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@MFlyer
Member

MFlyer commented Nov 28, 2016

Ref to forum thread https://forum.rockstor.com/t/wrong-tagging-in-smb-conf/2418 by user g6094199:

There's a minor "bug":
Samba AD Configuration closing tag has "BEGIN" instead of "END"

This doesn't raise any error and/or unexpected behaviour, one line fix coming now

@schakrava schakrava closed this in 3c28ff5 Nov 30, 2016

schakrava added a commit that referenced this issue Nov 30, 2016

Merge pull request #1549 from MFlyer/issue#1548_Samba_AD_Closing_tag
Fixes #1548, closing tag now has END instead of BEGIN

@schakrava schakrava changed the title from [Minor bug] Wrong Samba AD closing line to Wrong Samba AD closing line Dec 13, 2016

@schakrava schakrava added the bug label Dec 13, 2016

@schakrava schakrava added this to the Pinnacles milestone Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment