root and home shares offer delete button #1583

Closed
phillxnet opened this Issue Dec 13, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@phillxnet
Member

phillxnet commented Dec 13, 2016

I think it would be safer and more consistent to disable the delete button on the root and home shares. As is done with the root/system pool delete button. This could be done by a simply name filter as a standard install will always have them. Like wise the Access Control tabs on these shares could be disabled with an appropriate message indicating they are not available for this kind of change.

@schakrava schakrava added the bug label Dec 17, 2016

@schakrava schakrava added this to the Pinnacles milestone Dec 17, 2016

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Dec 17, 2016

Member

Note that on occasions the root share is named "root00", this has been seen in the current and last versions of the installer and when following the "Mirroring Rockstor OS using Linux Raid" install method. So we might also want to check for this subvolume name. Currently I think this is an installer quirk but one we might as well account for in this issue.

Member

phillxnet commented Dec 17, 2016

Note that on occasions the root share is named "root00", this has been seen in the current and last versions of the installer and when following the "Mirroring Rockstor OS using Linux Raid" install method. So we might also want to check for this subvolume name. Currently I think this is an installer quirk but one we might as well account for in this issue.

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 5, 2017

#1583 - Preserve system root and home shares in shares table page
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

@schakrava schakrava closed this in 103c072 Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment