balance cancel requested 'unit test' false alarm. #1627

Closed
phillxnet opened this Issue Jan 24, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@phillxnet
Member

phillxnet commented Jan 24, 2017

Thanks to @MFlyer for reporting this issue. In the background we have a unit test to check for correct balance 'cancel requested' status recognition. Due to a project wide refactoring pr recently #1615 that (almost) bring all Rockstor python code into compliance with Flake8 (mostly PEP8) standards, a minor error was introduced into this unit test.

./bin/test --settings=test-settings -v 2 -p test_btrfs*
test_balance_status_cancel_requested (fs.tests.test_btrfs.BTRFSTests) ... FAIL
...

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 24, 2017

@schakrava schakrava closed this in #1628 Feb 11, 2017

schakrava added a commit that referenced this issue Feb 11, 2017

Merge pull request #1628 from phillxnet/1627_balance_cancel_requested…
…_unit_test_false_alarm

correct minor refactoring error on balance unit test. Fixes #1627

@schakrava schakrava added the bug label Feb 11, 2017

@schakrava schakrava added this to the Point Bonita milestone Feb 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment