[Rockstor Devel Feature] Add Gulp file testing #1632

Closed
MFlyer opened this Issue Jan 29, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@MFlyer
Member

MFlyer commented Jan 29, 2017

Migrating from #1629 (closing it) to have a clean new issue

commits won't have any ref to issue to have it clean and with a different approach, starting from a working gulp + eslint without checks on unused vars (we have to decide how to have it / hack it all Rockstor js like a unique file)

@schakrava , @phillxnet , @priyaganti

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Jan 29, 2017

Member

Reference, Django Pipeline:

PIPELINE = {
    'DISABLE_WRAPPER': True,
    'JS_COMPRESSOR': None,
    'CSS_COMPRESSOR': None,
    'TEMPLATE_FUNC': 'Handlebars.compile',
    'JAVASCRIPT': {
        'storageadmin': {
            'source_filenames': (
                'storageadmin/js/license.js',
                'storageadmin/js/templates/**/*.jst',
                'storageadmin/js/templates/**/**/*.jst',
                'storageadmin/js/socket_listen.js',
                'storageadmin/js/rockstor.js',
                'storageadmin/js/rockstor_widgets.js',
                'storageadmin/js/rockstor_logger.js',
                'storageadmin/js/paginated_collection.js',
                'storageadmin/js/router.js',
                'storageadmin/js/graph.js',
                'storageadmin/js/d3.slider2.js',
                'storageadmin/js/models/models.js',
                'storageadmin/js/views/common/*.js',
                'storageadmin/js/views/*.js',
                'storageadmin/js/views/pool/**/*.js',
                'storageadmin/js/views/dashboard/*.js',
                ),
            'output_filename': 'storageadmin/js/storageadmin.js'
            },
        }
}
Member

MFlyer commented Jan 29, 2017

Reference, Django Pipeline:

PIPELINE = {
    'DISABLE_WRAPPER': True,
    'JS_COMPRESSOR': None,
    'CSS_COMPRESSOR': None,
    'TEMPLATE_FUNC': 'Handlebars.compile',
    'JAVASCRIPT': {
        'storageadmin': {
            'source_filenames': (
                'storageadmin/js/license.js',
                'storageadmin/js/templates/**/*.jst',
                'storageadmin/js/templates/**/**/*.jst',
                'storageadmin/js/socket_listen.js',
                'storageadmin/js/rockstor.js',
                'storageadmin/js/rockstor_widgets.js',
                'storageadmin/js/rockstor_logger.js',
                'storageadmin/js/paginated_collection.js',
                'storageadmin/js/router.js',
                'storageadmin/js/graph.js',
                'storageadmin/js/d3.slider2.js',
                'storageadmin/js/models/models.js',
                'storageadmin/js/views/common/*.js',
                'storageadmin/js/views/*.js',
                'storageadmin/js/views/pool/**/*.js',
                'storageadmin/js/views/dashboard/*.js',
                ),
            'output_filename': 'storageadmin/js/storageadmin.js'
            },
        }
}

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 29, 2017

#1632 Eslint license.js, socket_listen.js, rockstor.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 29, 2017

#1632 Eslint rockstor_widget.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 29, 2017

#1632 Eslint rockstor_logger.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 29, 2017

#1632 Eslint paginated_collection.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 29, 2017

#1632 Eslint router.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 29, 2017

#1632 Eslint graph.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 29, 2017

#1632 Eslint d3.slider.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 29, 2017

#1632 Eslint models.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 30, 2017

Fixes #1632 - Fixing unrequired console logging
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 30, 2017

#1632 - Fixing unrequired console logging regression
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 11, 2017

#1632 Relinting after Phil integrations
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 11, 2017

#1632 Found typo, fixed to avoid unexpected behaviours
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 11, 2017

#1632 ide open while fixing and reverted some linting
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 Eslint license.js, socket_listen.js, rockstor.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 Eslint rockstor_widget.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 Eslint rockstor_logger.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 Eslint paginated_collection.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 Eslint router.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 Eslint graph.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 Eslint d3.slider.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 Eslint models.js
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 - Fixing unrequired console logging regression
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 Relinting after Phil integrations
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 Found typo, fixed to avoid unexpected behaviours
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 ide open while fixing and reverted some linting
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 13, 2017

#1632 Relinting over master rebase
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

@schakrava schakrava closed this in fe47805 Feb 19, 2017

schakrava added a commit that referenced this issue Feb 19, 2017

@schakrava schakrava added this to the Pinnacles milestone Feb 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment