New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve state column clarity in network device tables #1633

Closed
phillxnet opened this Issue Jan 29, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@phillxnet
Member

phillxnet commented Jan 29, 2017

Thanks to Forum members Karney_Chen and @magicalyak in the following forum thread for highlighting this issue. In network device tables a 'State' column reports device state codes: these can be misinterpreted as network device speeds due to a common state code (connected) being 100, which is also a well known ethernet speed. However this column is parsed from nmcli's GENERAL.STATE output and is simply a status code.

Linking to issue #1630 where the source of this columns contents was established.

Forum thread associated with this and the above referenced issue:
https://forum.rockstor.com/t/jumbo-packets-possibility/2706/3

I propose that we change the network device table header from "State" to "Status code" there by clarifying the meaning of the codes there in.

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Jan 29, 2017

Member

I am currently having a look at resolving this issue as suggested.

Member

phillxnet commented Jan 29, 2017

I am currently having a look at resolving this issue as suggested.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 29, 2017

change 'State' to 'Status Code' in network device tables #1633
As a common state (connected) has the code of 100 this can be
misinterpreted as a common ethernet speed 'State' leading to a
misunderstanding of the contents of this column.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 29, 2017

@schakrava schakrava closed this in #1634 Feb 13, 2017

schakrava added a commit that referenced this issue Feb 13, 2017

Merge pull request #1634 from phillxnet/1633_improve_state_column_cla…
…rity_in_network_device_tables

improve state column clarity in network device tables. Fixes #1633

@schakrava schakrava added this to the Point Bonita milestone Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment