New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Comment" field not filled when editing Samba share #1647

Closed
maxhq opened this Issue Feb 8, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@maxhq
Contributor

maxhq commented Feb 8, 2017

When I go to "File Sharing" - "Samba" and edit an existing share the "Comment" field is not filled with the previously entered comment (which is corrently shown in the overview table).

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 9, 2017

Fixes #1647 - Fixing typo over field name
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Feb 9, 2017

Fixes #1647 - Fixing typo over field name - missing file
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Feb 9, 2017

Member

Thanks @maxhq , solved over #1649

Mirko

Member

MFlyer commented Feb 9, 2017

Thanks @maxhq , solved over #1649

Mirko

@maxhq

This comment has been minimized.

Show comment
Hide comment
@maxhq

maxhq Feb 9, 2017

Contributor

Wow, that is fast!
Take care that you do not solve problems before I report them or we'll end up in a time loop ;-P
Thanks a lot!

Contributor

maxhq commented Feb 9, 2017

Wow, that is fast!
Take care that you do not solve problems before I report them or we'll end up in a time loop ;-P
Thanks a lot!

@maxhq maxhq closed this Feb 9, 2017

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Feb 9, 2017

Member

Hi @maxhq next time don't close issues, PR for this and other need to be merged by @schakrava (on our commits we always have one "Fixes #issuenumber" and this auto-close issues 😉 )

Mirko

Member

MFlyer commented Feb 9, 2017

Hi @maxhq next time don't close issues, PR for this and other need to be merged by @schakrava (on our commits we always have one "Fixes #issuenumber" and this auto-close issues 😉 )

Mirko

@maxhq

This comment has been minimized.

Show comment
Hide comment
@maxhq

maxhq Feb 9, 2017

Contributor

Oh OK sorry, shall I reopen it?

Contributor

maxhq commented Feb 9, 2017

Oh OK sorry, shall I reopen it?

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Feb 9, 2017

Member

No problem Max, don't worry :)

Member

MFlyer commented Feb 9, 2017

No problem Max, don't worry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment