New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Shares view incorrect sort on size #1673

Closed
magicalyak opened this Issue Mar 14, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@magicalyak

magicalyak commented Mar 14, 2017

The sort on the UI for shares by size incorrectly uses the numeric values and ignores the TB,GB,MB values. So a 1TB usage will be ranked lower than a 9MB usage on the share.
What happens:
90.0 MB
8 TB
4 GB
2 MB
1 TB

What should happen:
8 TB
1 TB
4 GB
90.0 MB
2 MB

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Mar 14, 2017

Member

Hi @magicalyak ,
you're right about that - noticed while working on new share usage with btrfs "real" used space too.

Hopefully will stop over yum manager via WebUI #1619 and fix this before 3.9.0 release (@suman can you wait? Going to code this today/tomorrow :) )

Mirko

Member

MFlyer commented Mar 14, 2017

Hi @magicalyak ,
you're right about that - noticed while working on new share usage with btrfs "real" used space too.

Hopefully will stop over yum manager via WebUI #1619 and fix this before 3.9.0 release (@suman can you wait? Going to code this today/tomorrow :) )

Mirko

@magicalyak

This comment has been minimized.

Show comment
Hide comment
@magicalyak

magicalyak Mar 14, 2017

If you do end up just grabbing the text and parsing, make sure to include KB (I didn't list it but it's used). Hopefully you can get the value from a common denominator though. Size also has the same issue on the shares UI view (Size and Usage)

magicalyak commented Mar 14, 2017

If you do end up just grabbing the text and parsing, make sure to include KB (I didn't list it but it's used). Hopefully you can get the value from a common denominator though. Size also has the same issue on the shares UI view (Size and Usage)

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Mar 14, 2017

Member

Every size value over Rockstor views is byte and we get it KB, MB, etc via humanize js funcs, had an ad hoc function on another page fixing similar issue 😉

Member

MFlyer commented Mar 14, 2017

Every size value over Rockstor views is byte and we get it KB, MB, etc via humanize js funcs, had an ad hoc function on another page fixing similar issue 😉

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Mar 14, 2017

Member

DataTables has a builtin file size sorting function, so going to use it without rewrite it :)

EDIT: Going to patch DataTables plugin too eheh, some humanize values not recognized

Member

MFlyer commented Mar 14, 2017

DataTables has a builtin file size sorting function, so going to use it without rewrite it :)

EDIT: Going to patch DataTables plugin too eheh, some humanize values not recognized

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 14, 2017

Ref to #1673 - Adding DataTables file-size plugin dependency
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 14, 2017

Update to rockstor.js renderDataTables
Ref to #1673 - Instead of writing a DataTable func on every view
requiring custom params, we make default renderDataTables function
capable for accepting params (object - dict).
Passed dictionary extends default Rockstor DataTables dict

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 14, 2017

Pools page size sorting
Ref to #1673 - Apply same sorting to pools page

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 14, 2017

Adding size sorting on disks page
Ref to #1673 - Same as Shares and Pools

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Mar 14, 2017

Size sort over snapshots page
Ref to #1673 - Added this sorting too :)

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>

@schakrava schakrava closed this in def157f Mar 23, 2017

@schakrava schakrava added the bug label Mar 24, 2017

@schakrava schakrava added this to the Point Bonita milestone Mar 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment