New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non integer threshold value in SMART data blocks reporting #1725

Closed
phillxnet opened this Issue Jun 6, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@phillxnet
Member

phillxnet commented Jun 6, 2017

Thanks to forum member amtuannguyen in the following forum thread for reporting and assisting with this issue. Some drives return "---" as the value for all attribute thresholds. This results in the following error when the SMART 'Refresh' button is pressed:

ValueError: invalid literal for int() with base 10: '---'

consequently blocking Web UI parsing of the SMART data for these drives.

The drive in question was a:
Model Family: Seagate Constellation ES.3
Device Model: ST2000NM0033-9ZM175

I have prepared a fix / work around for this behaviour and will submit a pr shortly.

Please update the following forum thread with this issues resolution:
https://forum.rockstor.com/t/invalid-literal-for-int-with-base-10/3342

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 6, 2017

substitute smart attribute threshold '---' with '999' #1725
Some drives return "---" as a threshold value where as the
vast majority report an integer. To preserve this info we
substitute 999 in these cases given this is a more obvious
substitution than '0' which is a very common threshold value.

@schakrava schakrava closed this in #1726 Jun 9, 2017

schakrava added a commit that referenced this issue Jun 9, 2017

Merge pull request #1726 from phillxnet/1725_Non_integer_threshold_va…
…lue_in_SMART_data_blocks_reporting

substitute smart attribute threshold '---' with '999'. Fixes #1725

@schakrava schakrava added the bug label Jun 14, 2017

@schakrava schakrava added this to the Point Bonita milestone Jun 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment