New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ro rw degraded and skip_balance mount options #1728

Closed
phillxnet opened this Issue Jun 13, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@phillxnet
Member

phillxnet commented Jun 13, 2017

The additions of the 'ro' (read only) and 'degraded' mount options will reduce (but not remove) the need to resource the command line in data recovery / drive failure scenarios. Ie the combination of these mount options can allow for a safe degraded pool mount which in turn would allow for Web-UI directed access to data on degraded pools. And the combination of rw and degraded options will allow mounting a pool that has missing devices in order that they might be replaced or deleted if btrfs raid levels allow, and if not then a raid level change could be initiated followed directly by a then legitimate device delete: given the btrfs raid level change.

It is understood that we currently do not report pool mount status #737 and #1531 and ideally this would come first however the ongoing enhancements to pool mount logic in #1547 and the planned enhancement of #1700 have these mount options are prerequisites. And situations such as those presented in #1416 and #1199 would also benefit.

But given the current state of btrfs rw,degraded mount having certain 'one shot' limitation in low drive count for raid level situations, we may, in adding this level of flexibility, allow for more foot shooting. However we have a chicken and egg scenario here and have to start somewhere. Plus our first responsibility is to report the state of the system and allow for mount options where they are useful. It is not proposed that we default to a degraded mount.

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Jun 13, 2017

Member

I'm having a quick look at this issue now by way of a dependency for issue #1547.

Member

phillxnet commented Jun 13, 2017

I'm having a quick look at this issue now by way of a dependency for issue #1547.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 13, 2017

add ro rw degraded and skip_balance mount options #1728
Includes tooltip updates on Create Pool page and Pool
details page, a minor typo was also addressed. All
listings were adjusted to be in alphabetical order.
Associated test code was updated to include the new
options.

@schakrava schakrava closed this in #1729 Jun 14, 2017

schakrava added a commit that referenced this issue Jun 14, 2017

Merge pull request #1729 from phillxnet/1728_support_ro_rw_degraded_a…
…nd_skip_balance_mount_options

add ro rw degraded and skip_balance mount options. Fixes #1728

@schakrava schakrava added this to the Point Bonita milestone Jun 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment