New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor disk api regression follow up #1750

Closed
phillxnet opened this Issue Jul 2, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@phillxnet
Member

phillxnet commented Jul 2, 2017

An umbrella issue to address minor followup changes to recent important disk api changes.

  1. Partitioned device indicator (tags icon) in Create Pool dialog - link error
  2. Open LUKS volume indicator (eye-open icon) in Create Pool dialog - link error
  3. Certain 'Exception' import conditions lead to "%d format: a number is required, not unicode" (disk.py L489 / L711 _btrfs_disk_import).
  4. S.MA.R.T custom option api url format needs updating.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 2, 2017

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 2, 2017

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Jul 2, 2017

Member

1, 2, and 4 are now sorted by the attached commits.

Currently looking for a reproducer of 3 as shortly after experiencing the reported error the import worked as expected.

Member

phillxnet commented Jul 2, 2017

1, 2, and 4 are now sorted by the attached commits.

Currently looking for a reproducer of 3 as shortly after experiencing the reported error the import worked as expected.

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Jul 2, 2017

Member

@schakrava To me it looks like our 'did' is actually of type unicode. I'm going ahead and changing our Exception msg casting. I'll try and catch all in a single commit in case I have this backwards some how.

Member

phillxnet commented Jul 2, 2017

@schakrava To me it looks like our 'did' is actually of type unicode. I'm going ahead and changing our Exception msg casting. I'll try and catch all in a single commit in case I have this backwards some how.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 2, 2017

@schakrava schakrava closed this in #1751 Jul 2, 2017

schakrava added a commit that referenced this issue Jul 2, 2017

Merge pull request #1751 from phillxnet/1750_minor_disk_api_regressio…
…n_follow_up

minor disk api regression follow up. Fixes #1750

@schakrava schakrava added the bug label Jul 2, 2017

@schakrava schakrava added this to the Point Bonita milestone Jul 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment