regression - nvme system disk not identified #1951
Assignees
Comments
|
I have prepared a unit test that identifies this regression and defines the pre regression behaviour. This has been used to develop a fix that is under final test / preperation. Pull request to follow soon. |
phillxnet
added a commit
to phillxnet/rockstor-core
that referenced
this issue
Aug 14, 2018
Address nvme system disk regression, not recognised as attached, by improving the partition regex mechanism initially enhanced in commit a608d18 (pr rockstor#1949) which created the indicated regression. Summary: - Unit test added to instantiate observed nvme system disk regression and expected behaviour. - Simplify regex match conditional, for root partition identification, so that it again incorporates nvme device names: with root in partition. - Establish conditional partition regex prior to above match. - Enhance existing btrfs-in-partition unit test to catch a regression observed prior to establishing the above conditional regex that affected the 42nd scsi type drive 'sdap' if that drive had a btrfs partition concurrent with an 'sda' root drive name (and the prior regex's were 'or' combined). - Add debug logging of sys partition info inheritance from base device. - Add debug logging of btrfs in partition device skip: we only surface the base device. - Minor cosmetic bracket changes and comment updates. - Added TODO: on future option re base device identification from partition device name.
phillxnet
added a commit
to phillxnet/rockstor-core
that referenced
this issue
Aug 14, 2018
Address nvme system disk regression, not recognised as attached, by improving the partition regex mechanism initially enhanced in commit acbd6a5 (pr rockstor#1946) which created the indicated regression. Summary: - Unit test added to instantiate observed nvme system disk regression and expected behaviour. - Simplify regex match conditional, for root partition identification, so that it again incorporates nvme device names: with root in partition. - Establish conditional partition regex prior to above match. - Enhance existing btrfs-in-partition unit test to catch a regression observed prior to establishing the above conditional regex that affected the 42nd scsi type drive 'sdap' if that drive had a btrfs partition concurrent with an 'sda' root drive name (and the prior regex's were 'or' combined). - Add debug logging of sys partition info inheritance from base device. - Add debug logging of btrfs in partition device skip: we only surface the base device. - Minor cosmetic bracket changes and comment updates. - Added TODO: on future option re base device identification from partition device name.
schakrava
added a commit
that referenced
this issue
Aug 16, 2018
…_disk_not_identified regression - nvme system disk not identified. Fixes #1951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks to forum members Jorma_Tuomainen and Flox in the following thread for highlighting this regression. As from 3.9.2-31 pr #1946 nvme system disks were no longer identified as attached: resulting in, post update, the system disk showing as detached and consequently it's default surfaced share 'home', and any created post install, would fail to be available.
Associated log entry:
Where the Pool name may vary from install to install.
Non system pools / shares were not affected.
Please update the following forum thread with this issues resolution:
https://forum.rockstor.com/t/cant-start-rock-ons/5065
The text was updated successfully, but these errors were encountered: