New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flash websocket files #848

Closed
schakrava opened this Issue Sep 1, 2015 · 12 comments

Comments

Projects
None yet
3 participants
@schakrava
Member

schakrava commented Sep 1, 2015

do we really need

src/rockstor/storageadmin/static/storageadmin/js/WebSocketMain.swf
src/rockstor/storageadmin/static/storageadmin/js/WebSocketMainInsecure.swf

?

@schakrava schakrava added this to the Yosemite milestone Sep 1, 2015

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Jun 21, 2016

Member

Hi @schakrava , while digging around Rockstor issues I found this too.

Actually, considering every current browser, i think we don't need it anymore (maybe just for IE...):
this is current websockets support -> http://caniuse.com/#search=websocket so we should be ok without .swf, but we can leave it there for backward compatibility

Member

MFlyer commented Jun 21, 2016

Hi @schakrava , while digging around Rockstor issues I found this too.

Actually, considering every current browser, i think we don't need it anymore (maybe just for IE...):
this is current websockets support -> http://caniuse.com/#search=websocket so we should be ok without .swf, but we can leave it there for backward compatibility

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Jun 23, 2016

Member

to be closed (IMO) by @schakrava

Member

MFlyer commented Jun 23, 2016

to be closed (IMO) by @schakrava

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Oct 28, 2016

Member

Reminder to @schakrava - issue can be closed

Member

MFlyer commented Oct 28, 2016

Reminder to @schakrava - issue can be closed

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Oct 28, 2016

Member

@MFlyer As per your previous comment 21/6 , are you still proposing that we leave these files in place?
If they represent an arcane access method I would have thought a better / safer approach would be to remove them. That was my original thought anyway.

Member

phillxnet commented Oct 28, 2016

@MFlyer As per your previous comment 21/6 , are you still proposing that we leave these files in place?
If they represent an arcane access method I would have thought a better / safer approach would be to remove them. That was my original thought anyway.

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Oct 28, 2016

Member

Hi @phillxnet ,
we're in 2016 and every user should have a websockets enabled browser, but if all fail those two files grant websockets. I'm 👍 to remove them, but leaving them there grant websockets working over worst case too ( 99.999999999999999% those two will never be used )

Member

MFlyer commented Oct 28, 2016

Hi @phillxnet ,
we're in 2016 and every user should have a websockets enabled browser, but if all fail those two files grant websockets. I'm 👍 to remove them, but leaving them there grant websockets working over worst case too ( 99.999999999999999% those two will never be used )

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Oct 28, 2016

Member

@MFlyer It just concerns me to leave such things lying around, in the vein of sorting / cleaning as we go. Think we are in agreement on their lack of utility so probably shouldn't be there.

I vote for removal so they don't bit us back. The less old technology hanging around the better.

Member

phillxnet commented Oct 28, 2016

@MFlyer It just concerns me to leave such things lying around, in the vein of sorting / cleaning as we go. Think we are in agreement on their lack of utility so probably shouldn't be there.

I vote for removal so they don't bit us back. The less old technology hanging around the better.

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Oct 28, 2016

Member

My unique concern with tout court deleting:
our socket.io is 0.9.6 (04/2012) and reading current minified library code there's a reference to swf files

Best solution: upgrade socket.io having new socket.io lib without flash websockets (latest releases don't have it :) )

Member

MFlyer commented Oct 28, 2016

My unique concern with tout court deleting:
our socket.io is 0.9.6 (04/2012) and reading current minified library code there's a reference to swf files

Best solution: upgrade socket.io having new socket.io lib without flash websockets (latest releases don't have it :) )

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Oct 28, 2016

Member

@MFlyer
Agreed, better to upgrade gevent-socket.io and then remove these files, just in case. Good thinking.

And something that may be related:
The following has been niggling at me:
97a9b37
Note the comments in this commit. As can be seen we had an issue previously with a specific python version and it's compatibility re gevent which appears to have now passed as 2.7.5.39.el7_2 seems to be OK again.

Also note the following comment in this commit by @schakrava re move to tornado:
410ead2
When gevent and friends were locked down to the indicated versions.
ie gevent-socketio 0.3.6

Not my best area I'm afraid but given your knowledge on this one thought I'd bring it up for your perusal. Especially given the talk of upgrading these libraries. Looks like we need to spin out some additional issues here.

Member

phillxnet commented Oct 28, 2016

@MFlyer
Agreed, better to upgrade gevent-socket.io and then remove these files, just in case. Good thinking.

And something that may be related:
The following has been niggling at me:
97a9b37
Note the comments in this commit. As can be seen we had an issue previously with a specific python version and it's compatibility re gevent which appears to have now passed as 2.7.5.39.el7_2 seems to be OK again.

Also note the following comment in this commit by @schakrava re move to tornado:
410ead2
When gevent and friends were locked down to the indicated versions.
ie gevent-socketio 0.3.6

Not my best area I'm afraid but given your knowledge on this one thought I'd bring it up for your perusal. Especially given the talk of upgrading these libraries. Looks like we need to spin out some additional issues here.

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Oct 28, 2016

Member

Hi @phillxnet ,
i remember about gevent forced downgrade, those where my first days in Rockstor :)
We can nicely move socket.io js to latest - will test and PR asap - while updating to tornado or update gevent socletio imo is a 3.8-16 roadmap update to have more testing.

Member

MFlyer commented Oct 28, 2016

Hi @phillxnet ,
i remember about gevent forced downgrade, those where my first days in Rockstor :)
We can nicely move socket.io js to latest - will test and PR asap - while updating to tornado or update gevent socletio imo is a 3.8-16 roadmap update to have more testing.

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Oct 28, 2016

Member

@MFlyer Oops getting my socket.io libs and langs all mixed up by the looks of it. Oh well. Will have to put more time (when available) into this side of things.

Member

phillxnet commented Oct 28, 2016

@MFlyer Oops getting my socket.io libs and langs all mixed up by the looks of it. Oh well. Will have to put more time (when available) into this side of things.

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Oct 29, 2016

Member

Hi @phillxnet & @schakrava , here some updates:
Removed swf files and it seems ok with chrome/chromium & firefox, Safari supports websockets to and same should do IE by version 11

Moving socket.io from our 0.9.6 to latest 1.5.1 :
WOW, it's a mess. Code had major changes so had to check it and test it (new way to connect, etc etc etc) and except for that, with my first test I'm not sure our gevent-socketio is compatible :/

Member

MFlyer commented Oct 29, 2016

Hi @phillxnet & @schakrava , here some updates:
Removed swf files and it seems ok with chrome/chromium & firefox, Safari supports websockets to and same should do IE by version 11

Moving socket.io from our 0.9.6 to latest 1.5.1 :
WOW, it's a mess. Code had major changes so had to check it and test it (new way to connect, etc etc etc) and except for that, with my first test I'm not sure our gevent-socketio is compatible :/

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Oct 29, 2016

Member

gevent-socketio seems "dead", mantainer no more coding on it / taking care of PR.
Alternative found today : http://python-socketio.readthedocs.io/en/latest/

Compatible with socket.io 1.3.5+ - will checking on next Rockstor cycle

Member

MFlyer commented Oct 29, 2016

gevent-socketio seems "dead", mantainer no more coding on it / taking care of PR.
Alternative found today : http://python-socketio.readthedocs.io/en/latest/

Compatible with socket.io 1.3.5+ - will checking on next Rockstor cycle

@schakrava schakrava modified the milestones: Pinnacles, Yosemite Nov 13, 2016

@schakrava schakrava closed this in ea1c9be Nov 13, 2016

schakrava added a commit that referenced this issue Nov 13, 2016

Merge pull request #1504 from MFlyer/issue#848_Remove_unrequired_swf_…
…files

Fixes #848 - Removed flash websockets files

@schakrava schakrava changed the title from flash in websockets to Remove flash websocket files Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment