New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUT timed shutdown option #982

Closed
phillxnet opened this Issue Oct 23, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@phillxnet
Member

phillxnet commented Oct 23, 2015

Add the facility to GUI config a NUT initiated shutdown after a user chosen length of time. This would override the current default of only shutting down when On Battery (OB) and Low Battery (LB).
Please update the following forum post with progress on this issue:- http://forum.rockstor.com/t/ups-nut-rock-ons/592
Thanks to @g2_ufo on our forum for requesting this feature.

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Jun 13, 2016

Member

Adding the following forum thread / post as additional interest in this feature:
https://forum.rockstor.com/t/ups-service-fails-to-start/1609/3

Member

phillxnet commented Jun 13, 2016

Adding the following forum thread / post as additional interest in this feature:
https://forum.rockstor.com/t/ups-service-fails-to-start/1609/3

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Oct 3, 2016

Member

Further interest in NUT feature expansion expressed in the following forum thread:
https://forum.rockstor.com/t/failed-to-start-nut-ups-service-due-to-a-system-error/2135

Member

phillxnet commented Oct 3, 2016

Further interest in NUT feature expansion expressed in the following forum thread:
https://forum.rockstor.com/t/failed-to-start-nut-ups-service-due-to-a-system-error/2135

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 11, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 11, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 11, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 12, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 15, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 15, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 15, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 15, 2016

escape * char in match string and fix logic bug in parser #982
Given our target line contains a wild card char '*' we need to
escape this for literal char in sting match, this adds requirement
to split search pattern string from replacement string. Could be
done by inline char replacement / removal but this is simple fix
to fit current small scope of parser.
@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Oct 15, 2016

Member

Backend conf file parser is now mostly done (a little more testing once front end is in place).
TODO:

  • Add NUT shutdown timer selector to Web-UI NUT config page.
  • Ensure default shutdown timer setting is consistent with prior releases (ie disabled).
  • Correct / enhance conf template file explanatory comments.
  • Test real hw with timed shutdown option in all nut modes.
  • establish correct NUT client info is broadcast when in netserver mode for timed shutdown.
  • confirm sane behaviour when configured shutdown time period exceeds UPS capacity.
Member

phillxnet commented Oct 15, 2016

Backend conf file parser is now mostly done (a little more testing once front end is in place).
TODO:

  • Add NUT shutdown timer selector to Web-UI NUT config page.
  • Ensure default shutdown timer setting is consistent with prior releases (ie disabled).
  • Correct / enhance conf template file explanatory comments.
  • Test real hw with timed shutdown option in all nut modes.
  • establish correct NUT client info is broadcast when in netserver mode for timed shutdown.
  • confirm sane behaviour when configured shutdown time period exceeds UPS capacity.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 16, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 16, 2016

add handlebar helper and tooltip for nut shutdown timer selector #982
Plus minor smartd tooltip typos and spelling.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 16, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 16, 2016

make nut port placeholder text more informative #982 #1458
Several users have interpreted the previous "auto" placeholder
/ example text as an auto fill and so left it blank, this can in most
instances lead to a mis-configured nut. Changing the placeholder
text to represent more of a hint (it is already greyed out) should
help with this.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 16, 2016

establish a NUT backend port default of auto #982 #1458
By defaulting to auto for the port setting we cater for the
most common connection type going forward. This takes
effect when the port entry is left blank: a situation that
has proved to be common.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 16, 2016

establish a NUT backend shutdown timing default of 0 #982
By defaulting to 0, which effectively disables early 'timed'
shutdown by nut we preserve the prior behaviour before
timed shutdown was a config options. The front end already
defaults to 0 so here we ensure the backend does the same.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 16, 2016

additional safeguard on nut shutdown timer seconds value #982
Protect against receiving a 'seconds' string value that cannot be
interpreted as an integer. In this instance revert to the default of
seconds = '0', log the issue, and proceed.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 16, 2016

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 16, 2016

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Oct 16, 2016

Member

Next step is to prove / test on real hw as frontend and backend config edits appear to be working as intended.

Member

phillxnet commented Oct 16, 2016

Next step is to prove / test on real hw as frontend and backend config edits appear to be working as intended.

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Nov 13, 2016

Member

All forum threads referenced have been updated.

Member

phillxnet commented Nov 13, 2016

All forum threads referenced have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment