New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active directory, users/groups, charset #1283

Merged
merged 2 commits into from Apr 30, 2016

Conversation

Projects
None yet
3 participants

demount added some commits Apr 22, 2016

update users.py, charset, groupnames
Detect charset and decode groupname from grp.getgrgid.

link: https://forum.rockstor.com/t/users-groups-from-active-directory-with-utf-8-charset/1391

nb: it seems func get_users rewrited with a "hack" isnt affected by charset bug anymore, but i've added decode procedure there for any cases.
@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet Apr 22, 2016

Member

@demount Well done getting the pr ready.
Guess it's over to @schakrava to have a look now.

Member

phillxnet commented Apr 22, 2016

@demount Well done getting the pr ready.
Guess it's over to @schakrava to have a look now.

@schakrava schakrava merged commit c6600ef into rockstor:master Apr 30, 2016

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava Apr 30, 2016

Member

Thanks @demount! nicely done.

Btw, as a code contributor, you will get free stable subscription if you ever need one. Please contact support@rockstor.com for your discount code.

Member

schakrava commented Apr 30, 2016

Thanks @demount! nicely done.

Btw, as a code contributor, you will get free stable subscription if you ever need one. Please contact support@rockstor.com for your discount code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment