New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add/remove drives from single raid profile #1337

Merged
merged 1 commit into from Jun 12, 2016

Conversation

Projects
None yet
2 participants
@bskrtich
Contributor

bskrtich commented Jun 3, 2016

This fixes Issue #1048

@schakrava

This comment has been minimized.

Member

schakrava commented Jun 12, 2016

Welcome to core contributor club of Rockstor @bskrtich! Nicely done, and you get extra respect for test code. Everything checks out.

I do want to add a note here for future reference, that when removing a drive from a multi drive single profile our pre balance space check may pass, but btrfs balance could then come back with a no space left behind error, in which case the resize fails. No big deal in most cases, but the user will need to run a balance before retrying.

@schakrava schakrava merged commit bf7f0ab into rockstor:master Jun 12, 2016

@schakrava

This comment has been minimized.

Member

schakrava commented Jun 13, 2016

@bskrtich I've mentioned your contribution in our forum. Are you a user there? If so, please reply to the topic so we can properly attribute your contributions!

https://forum.rockstor.com/t/dev-log-for-3-8-14/1412/30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment