New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: argument to docker run should still be -d #1423

Merged
merged 1 commit into from Sep 7, 2016

Conversation

Projects
None yet
3 participants
@sfranzen
Contributor

sfranzen commented Aug 19, 2016

@schakrava Important, please merge/release ASAP. I overlooked that the command in this case was docker run. Passing daemon to this will cause it to take this as the image name, failing to install/run. Not sure why this did not appear while I tested this.

@fago

This comment has been minimized.

Show comment
Hide comment
@fago

fago Sep 4, 2016

I just ran into this in version: 3.8-14.10
Error caused by this:

Error: image library/daemon:latest not found

fago commented Sep 4, 2016

I just ran into this in version: 3.8-14.10
Error caused by this:

Error: image library/daemon:latest not found

@fago

This comment has been minimized.

Show comment
Hide comment
@fago

fago Sep 4, 2016

Note: I manually patched rockon_helpers.py and verified that this fixes the problem.

fago commented Sep 4, 2016

Note: I manually patched rockon_helpers.py and verified that this fixes the problem.

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava Sep 7, 2016

Member

ok finally got around to testing this out. Thanks @sfranzen and @fago!

Member

schakrava commented Sep 7, 2016

ok finally got around to testing this out. Thanks @sfranzen and @fago!

@schakrava schakrava merged commit 2f5f3a7 into rockstor:master Sep 7, 2016

@sfranzen sfranzen deleted the sfranzen:docker_journald branch Sep 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment