Flake8 satisfying style improvements and cleanup #1615

Merged
merged 17 commits into from Jan 15, 2017

Conversation

Projects
None yet
3 participants
@schakrava
Member

schakrava commented Jan 15, 2017

No description provided.

@schakrava schakrava merged commit 907f5c2 into rockstor:master Jan 15, 2017

1 check failed

default Build finished.
Details
@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Jan 16, 2017

Member

Hi @schakrava are we going with flake8 tests on jenkins builds? that would be nice :)

M.

Member

MFlyer commented Jan 16, 2017

Hi @schakrava are we going with flake8 tests on jenkins builds? that would be nice :)

M.

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava Jan 16, 2017

Member

yes @MFlyer . Please configure your IDE so all checks pass before opening pull requests!

Member

schakrava commented Jan 16, 2017

yes @MFlyer . Please configure your IDE so all checks pass before opening pull requests!

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Jan 16, 2017

Member

Actually will have fun, working on a centralized git repo from office & home, had flake8 on server and will manually auto-run against files with pre-commit hook 😉

Probably will have my first Rockstor-docu commit to how to contribute section about adding git pre-commit check :)

Member

MFlyer commented Jan 16, 2017

Actually will have fun, working on a centralized git repo from office & home, had flake8 on server and will manually auto-run against files with pre-commit hook 😉

Probably will have my first Rockstor-docu commit to how to contribute section about adding git pre-commit check :)

- substr = 'listen %d default_server' % port
+ if ((not http_server and
+ re.search('listen.*default_server', lines[i]) is not None)):
+ substr = 'listen %s:%d default_server' % (ip, port)

This comment has been minimized.

@schakrava

schakrava Jan 18, 2017

Member

So this line switched with 256 causing the nginx/ui bug

@schakrava

schakrava Jan 18, 2017

Member

So this line switched with 256 causing the nginx/ui bug

- e_msg = ('non-zero code(%d) returned by command: %s. output: %s error:'
- ' %s' % (rc, cmd, out, err))
+ e_msg = ('non-zero code({0}) returned by command: {1}. output: '
+ '{2} error: {3}'.format(rc, cmd, out, err))

This comment has been minimized.

@phillxnet

phillxnet Jan 20, 2017

Member

@schakrava Is this an intended edit, ie from %d %s etc to {0} {1}, don't we loose formatting capability this way?
Due to merge conflicts I'm hand converting my pr so need to know what you intended here.

@phillxnet

phillxnet Jan 20, 2017

Member

@schakrava Is this an intended edit, ie from %d %s etc to {0} {1}, don't we loose formatting capability this way?
Due to merge conflicts I'm hand converting my pr so need to know what you intended here.

@schakrava schakrava changed the title from Flake8 to Flake8 satisfying style improvements and cleanup Mar 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment