New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Jenkins' Flake8 regressions #1626

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
2 participants
@MFlyer
Member

MFlyer commented Jan 24, 2017

Jenkins' Flake8 doesn't like some files, so we fix them

Ready to be merged @schakrava

Can we have it running against PR diffs instead of all Rockstor repo structure? This can speed up flake8 task :)
Mirko

We love Jenkins and make it happy with Flake8
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Jan 24, 2017

Member

Add about building:

http://192.195.81.208:22082/job/build-rockstor-core/31/console

Yesterday had same issue while building share usage commits, had to bootstrap.py and rebuild

M.

Member

MFlyer commented Jan 24, 2017

Add about building:

http://192.195.81.208:22082/job/build-rockstor-core/31/console

Yesterday had same issue while building share usage commits, had to bootstrap.py and rebuild

M.

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer Jan 24, 2017

Member

@schakrava & @phillxnet :

After fetching PR on jenkins, instead of flake8 full Rockstor env we can check it against modified .py files:

flake8 $(git diff master --name-only | grep -i "\.py" | tr '\n' ' ')

git diff --name-only always returns \n separated files, so had to tr them

Mirko

Member

MFlyer commented Jan 24, 2017

@schakrava & @phillxnet :

After fetching PR on jenkins, instead of flake8 full Rockstor env we can check it against modified .py files:

flake8 $(git diff master --name-only | grep -i "\.py" | tr '\n' ' ')

git diff --name-only always returns \n separated files, so had to tr them

Mirko

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava Feb 6, 2017

Member

Thanks @MFlyer, nicely done!

Member

schakrava commented Feb 6, 2017

Thanks @MFlyer, nicely done!

@schakrava schakrava merged commit 715cb93 into rockstor:master Feb 6, 2017

1 check passed

default Build finished.
Details

@MFlyer MFlyer deleted the MFlyer:Jenkins_goes_camping branch Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment